Skip to content

Guard exifread 3.x IndexError on empty DJI MakerNote values #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrstear wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −0
Open

Guard exifread 3.x IndexError on empty DJI MakerNote values #2021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions opendm/photo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,20 @@
import math

import exifread
import exifread.core.exif_header as _exif_hdr
import numpy as np

# Workaround for exifread 3.x IndexError on empty DJI MakerNote tag values.
# exifread's ExifHeader._get_printable_for_field does str(values[0]) without
# guarding for an empty values list. Monkeypatch until upstream fixes it.
# See: https://github.com/ianare/exif-py/issues/254
_orig_get_printable = _exif_hdr.ExifHeader._get_printable_for_field
def _safe_get_printable(self, *args, **kwargs):
try:
return _orig_get_printable(self, *args, **kwargs)
except IndexError:
return ""
_exif_hdr.ExifHeader._get_printable_for_field = _safe_get_printable
from six import string_types
from datetime import datetime, timedelta, timezone

Expand Down