Skip to content

Fix issue #391 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lohedges merged 1 commit into from
Jan 8, 2026
Merged

Fix issue #391 #393

lohedges merged 1 commit into from
Jan 8, 2026

Conversation

@lohedges
Copy link
Contributor

@lohedges lohedges commented Jan 7, 2026

This PR closes #391 by fixing the Dynamics.get_rest2_scale method. I have moved the existing method the the DynamicsData class, then added the correct wrapper method to the Dynamics class itself.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@tom-potter-cresset

@lohedges lohedges added bug Something isn't working cresset related to work with cresset labels Jan 7, 2026
@tom-potter-cresset
Copy link
Collaborator

tom-potter-cresset commented Jan 8, 2026

This has fixed it for me, thanks

@lohedges lohedges merged commit 3af402d into devel Jan 8, 2026
4 of 5 checks passed
@lohedges lohedges deleted the fix_391 branch January 8, 2026 13:37
lohedges added a commit that referenced this pull request Jan 8, 2026
@lohedges
Backport fix from PR #393. [ci skip]
b0b331d
@lohedges lohedges mentioned this pull request Jan 8, 2026
Merged
lohedges added a commit that referenced this pull request Jan 8, 2026
@lohedges
Merge pull request #394 from OpenBioSim/backport_393
7fbd3f6 
Backport fix from PR #393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working cresset related to work with cresset

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Error when providing a lambda array to sire.Dynamics.current_potential_energy()

3 participants

@lohedges @tom-potter-cresset