Skip to content

fix: centralize drawer content spacing (#3278)#6124

Open
ded-furby wants to merge 2 commits into
OpenAEV-Platform:mainfrom
ded-furby:chore/drawer-spacing-issue-3278
Open

fix: centralize drawer content spacing (#3278)#6124
ded-furby wants to merge 2 commits into
OpenAEV-Platform:mainfrom
ded-furby:chore/drawer-spacing-issue-3278

Conversation

@ded-furby

@ded-furby ded-furby commented Jun 7, 2026

Copy link
Copy Markdown

Related issue

What changed

  • Added explicit Drawer API props to control spacing semantics: disableContainerPadding and containerMaxHeight.
  • Moved hardcoded per-call spacing (padding: 0, maxHeight: '100%') into Drawer prop usage for ATT&CK drawers.
  • Replaced inline containerStyle overrides in:
    • SelectTTPsDrawer
    • PaginationComponentV2
    • ExercisePopover

Why

This keeps spacing defaults in Drawer and reduces duplicated inline overrides across usage sites.

Validation

  • npm run check-ts (attempted) could not run: tsc is not available in this environment (sh: tsc: command not found).
  • npm run check script is not defined in openaev-front/package.json (attempted and received missing script error).

Copilot AI review requested due to automatic review settings June 7, 2026 14:59
@filigran-cla-bot filigran-cla-bot Bot added the cla:pending CLA signature required. label Jun 7, 2026
@filigran-cla-bot

Copy link
Copy Markdown

Contributor License Agreement

Hey @ded-furby!

Thank you for your contribution to Filigran! Before we can merge this pull request, we need you to sign our Contributor License Agreement (CLA).

Why do we need a CLA?

The CLA helps protect both you and Filigran. It ensures that:

  • You have the right to make this contribution
  • Filigran can use and distribute your contribution
  • Your contribution remains open source

How to sign

You can sign the CLA using either of these methods:

  1. 🔗 Sign directlyClick here to review and sign the CLA
  2. 📧 Via email — Check your inbox (and spam folder) for a signing invitation from Concord

Once signed, this comment will be automatically updated.


CLA not signed yet

This is an automated message from the Filigran CLA Bot. If you have questions, please contact the maintainers.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

Thank you for your contribution. This PR is but one step away from being ready for merging: all commits must be PGP-signed. To get started, please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR refactors Drawer container styling by introducing dedicated props to control padding and max-height, and updates callers to use these new props instead of passing containerStyle overrides.

Changes:

  • Added disableContainerPadding and containerMaxHeight props to Drawer.
  • Updated multiple Drawer call sites to use the new props (removing inline containerStyle padding/maxHeight overrides).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
openaev-front/src/components/common/queryable/pagination/PaginationComponentV2.tsx Switches to new Drawer props for padding/max-height in the ATT&CK Matrix drawer.
openaev-front/src/components/common/Drawer.tsx Introduces new props and applies them to the container <div> styling.
openaev-front/src/admin/components/simulations/simulation/ExercisePopover.tsx Uses disableContainerPadding instead of containerStyle padding override.
openaev-front/src/admin/components/scenarios/scenario/scenario_assistant/SelectTTPsDrawer.tsx Switches to new Drawer props for padding/max-height in the ATT&CK Matrix drawer.

Comment on lines +157 to 159
...(disableContainerPadding ? {} : { padding: '10px 20px 20px 20px' }),
...(containerMaxHeight ? { maxHeight: containerMaxHeight } : {}),
...containerStyle,
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.54%. Comparing base (812d826) to head (c28af5b).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
openaev-front/src/components/common/Drawer.tsx 0.00% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (1.90%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6124      +/-   ##
============================================
+ Coverage     41.22%   42.54%   +1.32%     
  Complexity     6731     6731              
============================================
  Files          2192     2237      +45     
  Lines         60725    61081     +356     
  Branches       7861     8024     +163     
============================================
+ Hits          25033    25989     +956     
+ Misses        34109    33404     -705     
- Partials       1583     1688     +105     
Flag Coverage Δ
backend 64.57% <ø> (ø)
e2e 16.88% <0.00%> (?)
frontend 1.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:pending CLA signature required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: revise spacing on the Drawer component

2 participants