Skip to content

fix(agent): changed embedding of vcc dlls in artefacts (#165)#189

Open
impolitepanda wants to merge 1 commit into
mainfrom
fix/165_agent_on_win_arm64
Open

fix(agent): changed embedding of vcc dlls in artefacts (#165)#189
impolitepanda wants to merge 1 commit into
mainfrom
fix/165_agent_on_win_arm64

Conversation

@impolitepanda

Copy link
Copy Markdown
Member

Proposed changes

  • Moved rustflag building (including the +crt-static flag) from the github action to the cargo config so that any compile command will use it and embed the required libraries

Testing Instructions

  1. Build agent on a windows Arm64 machine
  2. Execute it on a windows Arm64 machine that doesn't have the VCC preinstalled

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Copilot AI review requested due to automatic review settings June 9, 2026 13:17
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jun 9, 2026
@Filigran-Automation Filigran-Automation changed the title fix(agent): Changed embedding of vcc dlls in artefacts fix(agent): changed embedding of vcc dlls in artefacts (#165) Jun 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix Windows ARM64 agent startup failures caused by a missing VC runtime DLL by enforcing static CRT linkage via Cargo configuration (rather than CI-only flags), and adds a CI verification step to ensure the produced Windows binaries do not dynamically import VCRUNTIME.

Changes:

  • Move +crt-static from CI RUSTFLAGS into .cargo/config.toml target-specific rustflags for Windows MSVC targets.
  • Remove CI RUSTFLAGS setup to avoid overriding Cargo target-specific rustflags.
  • Add a Windows CI step that checks the built executable for dynamic VCRUNTIME dependencies.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/agent-ci.yml Removes CI RUSTFLAGS usage and adds a dependency check step for Windows builds.
.cargo/config.toml Adds Windows MSVC target rustflags to force static CRT linkage and attempts to centralize symbol stripping.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .cargo/config.toml Outdated
Comment thread .github/workflows/agent-ci.yml Outdated
@impolitepanda impolitepanda force-pushed the fix/165_agent_on_win_arm64 branch 4 times, most recently from c8ec765 to 4b8b5c4 Compare June 9, 2026 14:04
@impolitepanda impolitepanda force-pushed the fix/165_agent_on_win_arm64 branch from 4b8b5c4 to 4b7927a Compare June 9, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: agent not starting on Windows arm64 (missing VC140RUNTIME.dll)

2 participants