fix(agent): changed embedding of vcc dlls in artefacts (#165)#189
Open
impolitepanda wants to merge 1 commit into
Open
fix(agent): changed embedding of vcc dlls in artefacts (#165)#189impolitepanda wants to merge 1 commit into
impolitepanda wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Windows ARM64 agent startup failures caused by a missing VC runtime DLL by enforcing static CRT linkage via Cargo configuration (rather than CI-only flags), and adds a CI verification step to ensure the produced Windows binaries do not dynamically import VCRUNTIME.
Changes:
- Move
+crt-staticfrom CIRUSTFLAGSinto.cargo/config.tomltarget-specificrustflagsfor Windows MSVC targets. - Remove CI
RUSTFLAGSsetup to avoid overriding Cargo target-specificrustflags. - Add a Windows CI step that checks the built executable for dynamic VCRUNTIME dependencies.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/agent-ci.yml |
Removes CI RUSTFLAGS usage and adds a dependency check step for Windows builds. |
.cargo/config.toml |
Adds Windows MSVC target rustflags to force static CRT linkage and attempts to centralize symbol stripping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c8ec765 to
4b8b5c4
Compare
4b8b5c4 to
4b7927a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Related issues
Checklist