chore: add agent smoke test workflows for CI and nightly runs#187
Open
guillaumejparis wants to merge 1 commit into
Open
chore: add agent smoke test workflows for CI and nightly runs#187guillaumejparis wants to merge 1 commit into
guillaumejparis wants to merge 1 commit into
Conversation
Member
|
🤖 [AI-generated] Hey @guillaumejparis! 👋 I'm Sam, your convention guardian. I reviewed PR #187 and here's what I adjusted: 🏷️ Labels
📋 PR Description QualityOverall: Incomplete ❌ I haven't changed anything in your description — just flagging a few things to improve when you get a chance 🙏
Thanks for contributing! 🚀 |
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions workflows to run cross-platform “smoke tests” for released agent binaries on both PRs and a nightly schedule, factoring the smoke-test logic into a reusable composite action.
Changes:
- Add a nightly scheduled workflow running an OS/arch runner matrix for agent smoke testing.
- Add a PR-level smoke-test job to the existing CI workflow (smaller “latest runners” matrix).
- Introduce a composite action that downloads the released agent binary from JFrog, writes a smoke-test config, and runs the smoke test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| .github/workflows/nightly-ci.yml | New scheduled workflow to run agent smoke tests across a broader runner matrix nightly and on manual dispatch. |
| .github/workflows/agent-ci.yml | Adds a PR-level smoke-test job using the composite action on a smaller runner matrix. |
| .github/actions/agent-implant-smoke/action.yml | New composite action implementing the download/configure/run smoke-test procedure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if: inputs.os != 'windows' | ||
| shell: bash | ||
| run: | | ||
| set +e |
Comment on lines
+93
to
+98
| if grep -qiE "$PATTERN" "$log_file"; then | ||
| echo "✅ $binary: connection error detected (binary starts correctly)" | ||
| else | ||
| echo "❌ $binary: no connection error found in logs" | ||
| return 1 | ||
| fi |
Comment on lines
+142
to
+148
| if ($allLogs -match $pattern) { | ||
| Write-Host "✅ ${Binary}: connection error detected (binary starts correctly)" | ||
| return $true | ||
| } else { | ||
| Write-Host "❌ ${Binary}: no connection error found in logs" | ||
| return $false | ||
| } |
Comment on lines
+2
to
+5
| description: > | ||
| Downloads the openaev-agent binary from JFrog, launches it with a fake | ||
| config pointing at localhost:1, and asserts it fails with a connection | ||
| error (proving the binary starts and reaches the network layer). |
|
|
||
| jobs: | ||
| # ────────────────────────────────────────────────────────────────── | ||
| # Agent & Implant smoke tests — full OS/arch/version matrix. |
| # config pointing at localhost:1, and asserts they produce a | ||
| # connection error (proving startup + network-layer reach). | ||
| # | ||
| # 13 runners covering all supported OS versions and architectures. |
Comment on lines
+88
to
+92
| - name: Run agent & implant smoke tests | ||
| uses: ./.github/actions/agent-implant-smoke | ||
| with: | ||
| os: ${{ matrix.os }} | ||
| jfrog-arch: ${{ matrix.jfrog-arch }} |
Comment on lines
+403
to
+407
| # Agent & Implant smoke tests (PR-level, latest runners only). | ||
| # | ||
| # Downloads released binaries from JFrog, starts them with a fake | ||
| # config pointing at localhost:1, and asserts they produce a | ||
| # connection error (proving startup + network-layer reach). |
Comment on lines
+445
to
+449
| - name: Run agent & implant smoke tests | ||
| uses: ./.github/actions/agent-implant-smoke | ||
| with: | ||
| os: ${{ matrix.os }} | ||
| jfrog-arch: ${{ matrix.jfrog-arch }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Related issues
Checklist
Further comments