Merged
Conversation
yonromai
force-pushed
the
romain/notebook-scripts
branch
from
6b71110 to
2063943
Compare
ravwojdyla
approved these changes
Jun 19, 2025
| fi | ||
|
|
||
| # 3. Define repository details | ||
| REPO_URL="https://github.com/tabtab-labs/caduceus-distill.git" |
Contributor
Author
There was a problem hiding this comment.
(This still works with the auto-redirect, but) it's fixed in #10
| print(f" Warm-up on {gpu_device} complete.") | ||
|
|
||
| except Exception as e: | ||
| print(f" An error occurred during warm-up on {gpu_device}: {e}") |
Contributor
There was a problem hiding this comment.
Printing traceback here could make this more readable. You can see in #11. But in general this seems like a good use case for logger.exception 🤔
Contributor
Author
There was a problem hiding this comment.
Great point, I'll add this tomorrow, when I debug the issue with NVidia driver. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.