fix(usePromiseResult): guard cancelIdleCallback for Safari/WKWebView#10812
Open
huhuanming wants to merge 1 commit intoxfrom
Open
fix(usePromiseResult): guard cancelIdleCallback for Safari/WKWebView#10812huhuanming wants to merge 1 commit intoxfrom
huhuanming wants to merge 1 commit intoxfrom
Conversation
…Native cancelIdleCallback is not available in Safari/WKWebView. The cleanup function referenced it unconditionally, causing a ReferenceError even though idleHandles was only populated on native. Mirror the existing isNative guard from the push side to the cleanup side.
huhuanming
requested review from
ezailWang,
originalix,
revan-zhang and
sidmorizon
as code owners
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReferenceError: Can't find variable: cancelIdleCallbackon iOS WKWebView (Safari)usePromiseResultreferencedcancelIdleCallbackunconditionally, but this API doesn't exist in Safari/WKWebViewplatformEnv.isNativeguard to the cleanup, mirroring the existing guard on the push sideTest plan
usePromiseResulttests pass/perps