feat(lint): upgrade oxlint to 1.56.0 and enable no-shadow/no-use-before-define to align with ESLint#10809
Open
huhuanming wants to merge 2 commits intoxfrom
Open
feat(lint): upgrade oxlint to 1.56.0 and enable no-shadow/no-use-before-define to align with ESLint#10809huhuanming wants to merge 2 commits intoxfrom
huhuanming wants to merge 2 commits intoxfrom
Conversation
Upgrade oxlint from 1.43.0 to 1.56.0 and enable two new lint rules: - no-shadow: detect variable shadowing in outer scopes - no-use-before-define: disallow usage before declaration Fix all existing no-shadow violations across the codebase.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
huhuanming
requested review from
ezailWang,
originalix,
revan-zhang and
sidmorizon
as code owners
huhuanming
changed the title
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-shadowandno-use-before-definelint rulesno-shadowviolations across the codebaseChanges
apps/mobile/plugins/index.jspath→filePathapps/mobile/metro.config.jspath→p,config→cfgapps/mobile/plugins/linkAssets.jslinkAssets→copyAssetdevelopment/webpack/ext/devUtils.jsisManifestV3()development/webpack/webpack.base.config.jspath→assetPathdevelopment/perf-ci/lib/perfServer.jshealth→serverHealthpackages/kit/.../TokenDetails/index.tsxresult→nameMappackages/shared/.../polyfillsPlatform.jsfr→innerReaderTest plan
yarn lint:onlypasses with no new errors from these rules