refactor: keyless cloud sync UX (OK-50738 OK-51225)#10727
Draft
franco-chan wants to merge 18 commits intoxfrom
Draft
refactor: keyless cloud sync UX (OK-50738 OK-51225)#10727franco-chan wants to merge 18 commits intoxfrom
franco-chan wants to merge 18 commits intoxfrom
Conversation
…mode - Replace all hardcoded strings with i18n keys via Lokalise - Add mode-aware security content in CloudSyncInfo page - Keyless mode shows wallet-derived encryption description - OneKey ID mode keeps original password-based description - Update Scenario 1 layout with cloud icon and CTA - Use restore_keyless_wallet for Scenario 5 alert button
Apply the same auto-lock duration check (disallow 4h/Never) when enabling keyless wallet sync, matching the existing OneKey ID sync behavior. Also fix migration step order, add error feedback, gate reloadServerUserInfo to Scenario 4, remove dead ref, and replace hardcoded string with i18n key.
…ions - Auto-enable keyless cloud sync on wallet creation (all entry points) - Auto-migrate ID→Keyless sync when creating KW with ID sync active - Show actionable error toast when ID sync fails silently in background - Add Toast.dismiss() API and custom icon support for toast messages - Simplify Cloud Sync page: new illustration, wallet info ListItem, remove success toasts, remove keyless auto-lock restriction
- Hide Debug button behind platformEnv.isDev in production builds - Add !kwLoading guard to isActiveKwUser to prevent Scenario 3 flash - Add isSubmittingRef guard to handleMigrateToKeyless to prevent concurrent migration on rapid double-tap
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- Change dismissToast param from string|number to string (native toast lib only accepts string|undefined) - Move actionLayout from $sm responsive prop to direct prop (Tamagui $sm only accepts style props, not custom variants)
- Remove OneKey Cloud item from PrimeBenefitsList - Remove OneKey Cloud slide from PrimeFeatures swiper - Change PrimeDashboard ? button default feature to BulkCopyAddresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🔗 OK-50738 | OK-51225