Merged
Conversation
ragaumon
added
Bug
Grabauskas
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Zaken API response mapping for NatuurlijkPersoonZaakRol so GET responses use the new inpbsn_encrypted-backed field rather than the legacy inpbsn field, and aligns the unit test accordingly.
Changes:
- Map
NatuurlijkPersoonZaakRolDto.InpBsnfromNatuurlijkPersoonZaakRol.InpBsnEncryptedinDomainToResponseProfile. - Update mapping unit test to assert
InpBsncomes fromInpBsnEncrypted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/OneGround.ZGW.Zaken.Web/MappingProfiles/v1/DomainToResponseProfile.cs | Changes response mapping to use InpBsnEncrypted for GET output. |
| src/Tests/OneGround.ZGW.Zaken.WebApi.UnitTests/MappingTests/DomainToResponseProfileTests.cs | Updates mapping test expectation to match the new source field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
For Get use bsn_encrypt field
Type of Change
Related Issues
Testing
Checklist