Properly handle task cancelation in ResponseRouter#1190
Open
ycholette wants to merge 2 commits intoOmniSharp:masterfrom
Open
Properly handle task cancelation in ResponseRouter#1190ycholette wants to merge 2 commits intoOmniSharp:masterfrom
ycholette wants to merge 2 commits intoOmniSharp:masterfrom
Conversation
4fc7cb1 to
71ef7e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We stumble into a case where we wanted to add timeout to Initialize() and Shutdown() because those two methods can potentially never return. In the case of
Shutdow(), it seems to be happening inRequestShutdown()when the client's process has already exited. This allow for the rest of the method to be executed when the timeout is reached (important if you want to reconnect again). For the case if Initialize(), the reason is not clear, but it seems to happen inSendRequest(ClientSettings, token). It's possible that the client's process is not totally ready to accept connection. In any cases, a timeout really help in those cases.