Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In Always use system TLS defaults (Halibut#706) Halibut is removing the ability to configure TLS protocols, instead delegating to the underlying Operating System.
This PR updates Tentacle to allow Halibut to use Operating System TLS configruation.
Results
OCTOPUS_TENTACLE_USE_LEGACY_TLSoverride, which would allow explicitly setting all TLS protocols as supported.Before
OCTOPUS_TENTACLE_USE_LEGACY_TLSenvironment variable.After
OCTOPUS_TENTACLE_USE_LEGACY_TLSwill have no effect. The Operating System default enabled TLS protocols will be used. The new behaviour will be as if the environment variable was not set.If you Operating System is misconfigured you may not have access to newer TLS protocols required to connect to Octopus Server.
How to review this PR
Quality ✔️
Pre-requisites