Skip to content

Migrate from deprecated Microsoft.Azure.Management.Fluent to …#1859

Open
zentron wants to merge 3 commits intomainfrom
robe/azure-refactor
Open

Migrate from deprecated Microsoft.Azure.Management.Fluent to …#1859
zentron wants to merge 3 commits intomainfrom
robe/azure-refactor

Conversation

@zentron
Copy link
Copy Markdown
Contributor

@zentron zentron commented Apr 1, 2026

…Azure.ResourceManager SDK

Replaces the EOL Fluent SDK (retired Sep 2023) with the Azure.ResourceManager Track 2 SDK across Calamari.CloudAccounts and Calamari.Azure:

  • Remove Microsoft.Azure.Management.Fluent and Microsoft.Rest.ClientRuntime packages
  • Drop IAzureAccount.CreateAzureClient() (IAzure); AKS discovery now uses the existing CreateArmClient() extension in AzureClient.cs
  • Migrate AzureKubernetesDiscoverer to Azure.ResourceManager.ContainerService (resource groups via GetResourceGroups().GetAll(), clusters via GetContainerServiceManagedClusters().GetAll(), CloudException -> RequestFailedException)
  • Remove AzureKnownEnvironment dependency on Fluent AzureEnvironment; validation is now done via the existing ToArmEnvironment() switch
  • Remove unused Credentials() extension methods that returned Microsoft.Rest ServiceClientCredentials (callers already use GetAuthorizationToken directly)

⚠️ Does this change require a corresponding Server Change?
⚠️ If so - please add a "Requires Server Change" label to this PR!

…sourceManager SDK

Replaces the EOL Fluent SDK (retired Sep 2023) with the Azure.ResourceManager
Track 2 SDK across Calamari.CloudAccounts and Calamari.Azure:

- Remove Microsoft.Azure.Management.Fluent and Microsoft.Rest.ClientRuntime packages
- Drop IAzureAccount.CreateAzureClient() (IAzure); AKS discovery now uses the
  existing CreateArmClient() extension in AzureClient.cs
- Migrate AzureKubernetesDiscoverer to Azure.ResourceManager.ContainerService
  (resource groups via GetResourceGroups().GetAll(), clusters via
  GetContainerServiceManagedClusters().GetAll(), CloudException -> RequestFailedException)
- Remove AzureKnownEnvironment dependency on Fluent AzureEnvironment; validation
  is now done via the existing ToArmEnvironment() switch
- Remove unused Credentials() extension methods that returned Microsoft.Rest
  ServiceClientCredentials (callers already use GetAuthorizationToken directly)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@zentron zentron force-pushed the robe/azure-refactor branch from b967e1a to 3125057 Compare April 2, 2026 00:29
@zentron
Copy link
Copy Markdown
Contributor Author

zentron commented Apr 2, 2026

@zentron zentron marked this pull request as ready for review April 2, 2026 01:50
Copy link
Copy Markdown
Contributor

@APErebus APErebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restored the deleting ProvisioningState check and tweaked some other minor things. Otherwise, seems good to me. Will be nice to get rid of that code finally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants