Explicitly set xr.merge behaviour to anticipate future xarray changes#1647
Open
LOCEANlloydizard wants to merge 2 commits intoOSOceanAcoustics:mainfrom
Open
Explicitly set xr.merge behaviour to anticipate future xarray changes#1647LOCEANlloydizard wants to merge 2 commits intoOSOceanAcoustics:mainfrom
LOCEANlloydizard wants to merge 2 commits intoOSOceanAcoustics:mainfrom
Conversation
- Add explicit compat="no_conflicts" and join="outer" to xr.merge calls - Anticipate upcoming xarray default changes (join='exact', compat='override') - Applied to EK60 and EK80 group assembly (convert module) Fix OSOceanAcoustics#1601 OSOceanAcoustics#1540
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
=======================================
Coverage 85.58% 85.59%
=======================================
Files 79 79
Lines 6998 7016 +18
=======================================
+ Hits 5989 6005 +16
- Misses 1009 1011 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Set explicit join in xr.concat for EK60 beam assembly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1601 #1540