Skip to content

Return tau_effective from compute_Sv and update tau_effective handling#1621

Open
LOCEANlloydizard wants to merge 19 commits intoOSOceanAcoustics:mainfrom
LOCEANlloydizard:tau-effective-power-sample
Open

Return tau_effective from compute_Sv and update tau_effective handling#1621
LOCEANlloydizard wants to merge 19 commits intoOSOceanAcoustics:mainfrom
LOCEANlloydizard:tau-effective-power-sample

Conversation

@LOCEANlloydizard
Copy link
Copy Markdown
Collaborator

@LOCEANlloydizard LOCEANlloydizard commented Mar 10, 2026

Adding CW validation tests for tau_effective and return tau_effective from compute_Sv

  • add tau_effective in the power-encoding path
  • add EK80 CW validation tests for power-encoded data against Matecho and pyEcholab
  • add EK80 CW validation tests for complex-encoded data against Matecho and Echoview
  • compare both tau_effective and Sv outputs
  • return tau_effective in compute_Sv for both power and complex encode paths

@LOCEANlloydizard LOCEANlloydizard changed the title Add CW calibration validation tests for EK60/EK80 (power and complex)… Return tau_effective from compute_Sv and update tau_effective handling Mar 11, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.60%. Comparing base (6cf6cee) to head (8d5a52d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
echopype/calibrate/calibrate_ek.py 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
+ Coverage   85.58%   85.60%   +0.01%     
==========================================
  Files          79       79              
  Lines        6998     7021      +23     
==========================================
+ Hits         5989     6010      +21     
- Misses       1009     1011       +2     
Flag Coverage Δ
integration 80.67% <87.50%> (+0.03%) ⬆️
unit 60.54% <87.50%> (+0.12%) ⬆️
unittests 85.50% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leewujung leewujung moved this to In Progress in Echopype 2026 Apr 2, 2026
@leewujung leewujung moved this from In Progress to In Review in Echopype 2026 Apr 2, 2026
@LOCEANlloydizard LOCEANlloydizard added the enhancement This makes echopype better label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This makes echopype better

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants