Database: update to EPSG v12.049#4671
Conversation
jjimenezshaw
left a comment
There was a problem hiding this comment.
I see that despite the new bunch of members of ETRS89, no test had to be changed. Is that good or bad? I know you changed before it so WKTs are be more flexible related to the members of datum ensembles.
I noticed some reordering (without apparent changes) of entries that make reviewing more complicated. Like in the alias_name.sql or helmert_transformation.sql. How are those files ordered?
I was surprised too but I guess we have been careful writing the test to not being dependent on the exact content of the ensemble
I made a change some time ago to accept a WKT where the members of the ensemble would be omitted, but the writing side write them all. ETRS89 is now super lengthy:
I suspect mostly from the order from the EPSG .sql dump. Although we insert them in a temporary sqlite db, so this could potentially depend on the SQLite version when we SELECT without ORDER (although I believe the current implementation must return in the same order as the insertion one) |
|
Ordering in sqlite is undefined unless you use an explicit order. There is an easy pragma (PRAGMA reverse_unordered_selects;) to see where you depend on unspecified ordering, as that explicitly makes everything with undefined order return in the opposite order. (This only breaks if your tests have the same bug ;-)) Typically it will just use the cheapest way, but that really depends on what indexes are used after optimizing the query. But that may change with versions. |
No description provided.