Skip to content

Add link to Software License page in dashboard footer#4722

Merged
johrstrom merged 1 commit intomasterfrom
achalker-patch-1
Oct 24, 2025
Merged

Add link to Software License page in dashboard footer#4722
johrstrom merged 1 commit intomasterfrom
achalker-patch-1

Conversation

@achalker
Copy link
Contributor

Per some recommendations on Open Source Software best practices, we should link to our software license info in the footer of the dashboard.

I've tested this on the live OSC OnDemand site by editing the page and it looks like this:
image

Per some recommendations on Open Source Software best practices, we should link to our software license info in the footer of the dashboard.
Copy link
Contributor

@Bubballoo3 Bubballoo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this link directly to the MIT license in github? The linked page mentions that

Open OnDemand code is released under the MIT License. Documentation and most publications are released under the CC BY 4.0 License

Since the OnDemand instance is the code (and thus governed by the MIT license), I wonder if adding a page in between is necessary. We could have a similar link in the docs to the CC BY 4.0, and same with the "most publications" mentioned. Just an idea though open to other considerations.

@achalker
Copy link
Contributor Author

Good question. I'm anticipating us having some sort of additional documentation that lists off all the components / 3rd party dependencies and their associated licenses (Travis is working on that). I don't know that it's appropriate to link to that from the existing license.txt file, so I figured we'd have some sort of landing page that points to all the other appropriate info (hence openondemand.org/license).

@johrstrom johrstrom closed this Oct 24, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Review to Merged/Closed in PR Review Pipeline Oct 24, 2025
@johrstrom johrstrom reopened this Oct 24, 2025
@github-project-automation github-project-automation bot moved this from Merged/Closed to Awaiting Review in PR Review Pipeline Oct 24, 2025
@johrstrom johrstrom self-requested a review October 24, 2025 19:45
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the link later if we need.

@johrstrom johrstrom merged commit 94301a6 into master Oct 24, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Review to Merged/Closed in PR Review Pipeline Oct 24, 2025
@johrstrom johrstrom deleted the achalker-patch-1 branch October 24, 2025 19:46
harshit-soora pushed a commit to harshit-soora/ondemand that referenced this pull request Oct 31, 2025
Per some recommendations on Open Source Software best practices, we should link to our software license info in the footer of the dashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants