Merged
Conversation
Contributor
It isn't a bug as |
Contributor
Author
|
True, but I am always concerned about sometime in the future refactoring the code and suddenly it becomes a bug. Plus this does hinder readability. |
johrstrom
approved these changes
Oct 28, 2025
Contributor
johrstrom
left a comment
johrstrom
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
github-project-automation
bot
moved this from Awaiting Review
to Merged/Closed
in PR Review Pipeline
harshit-soora
pushed a commit
to harshit-soora/ondemand
that referenced
this pull request
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like this is bug. Or, perhaps some of the "ws." need to be changed to "this.".