Enhancement: remove unnecessary second analyze #265
Merged
pelesh merged 4 commits intorefactor-examples-devfrom May 8, 2025
Merged
Enhancement: remove unnecessary second analyze #265pelesh merged 4 commits intorefactor-examples-devfrom
pelesh merged 4 commits intorefactor-examples-devfrom
Conversation
Collaborator
|
So with this modification, the solution to system |
pelesh
approved these changes
May 8, 2025
Collaborator
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
The fix to SystemSolver class was trivial so I pushed it here directly. Everything works fine now.
pelesh
added a commit
that referenced
this pull request
May 9, 2025
* Analysis is done only once in examples. * Fix bug in SystemSolver class. --------- Co-authored-by: Slaven Peles <peless@ornl.gov>
maksud
pushed a commit
that referenced
this pull request
May 9, 2025
* Analysis is done only once in examples. * Fix bug in SystemSolver class. --------- Co-authored-by: Slaven Peles <peless@ornl.gov>
pelesh
added a commit
that referenced
this pull request
May 12, 2025
* Better CLI input. * Remove obsolete code. * Read vectors directly from the file. * Add print system info function to the helper. * Rename r_KLU_rocSolverRf_FGMRES.cpp -> gpuRefactor.cpp * Fix bug in system solver CUDA example. * Rewrote GPU refactor so it works w/CUDA or HIP Co-authored-by: Shaked Regev <shakedvregev@gmail.comregev@gmail.com> Co-authored-by: pelesh <peless@ornl.gov> * Refactor randomized GMRES examples CPU, CUDA, HIP all work with the same source file. Eliminated redundant code. Added ExampleHelper to declutter the code and added details about how to use the various solvers. * Enable turning off IR in gpuRefactor. * Refactor examples for SystemSolver class (#252) --------- Co-authored-by: Shaked Regev <shakedvregev@gmail.comregev@gmail.com> Co-authored-by: Slaven Peles <peless@ornl.gov> * Refactor and stand alone examples for KLU class (#253) * Enhancement: remove unnecessary second analyze (#265) * Fix bug in SystemSolver class. --------- Co-authored-by: Slaven Peles <peless@ornl.gov> * Move experiemental examples to different directory. --------- Co-authored-by: shakedregev <35384901+shakedregev@users.noreply.github.com> Co-authored-by: Shaked Regev <shakedvregev@gmail.comregev@gmail.com>
pelesh
added a commit
that referenced
this pull request
May 13, 2025
* Better CLI input. * Remove obsolete code. * Read vectors directly from the file. * Add print system info function to the helper. * Rename r_KLU_rocSolverRf_FGMRES.cpp -> gpuRefactor.cpp * Fix bug in system solver CUDA example. * Rewrote GPU refactor so it works w/CUDA or HIP Co-authored-by: Shaked Regev <shakedvregev@gmail.comregev@gmail.com> Co-authored-by: pelesh <peless@ornl.gov> * Refactor randomized GMRES examples CPU, CUDA, HIP all work with the same source file. Eliminated redundant code. Added ExampleHelper to declutter the code and added details about how to use the various solvers. * Enable turning off IR in gpuRefactor. * Refactor examples for SystemSolver class (#252) --------- Co-authored-by: Shaked Regev <shakedvregev@gmail.comregev@gmail.com> Co-authored-by: Slaven Peles <peless@ornl.gov> * Refactor and stand alone examples for KLU class (#253) * Enhancement: remove unnecessary second analyze (#265) * Fix bug in SystemSolver class. --------- Co-authored-by: Slaven Peles <peless@ornl.gov> * Move experiemental examples to different directory. --------- Co-authored-by: shakedregev <35384901+shakedregev@users.noreply.github.com> Co-authored-by: Shaked Regev <shakedvregev@gmail.comregev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kluRefactor,sysRefactor, andgpuRefactorwere all performing a redundant second analyze.Proposed changes
Made sure analyze is only done once. All tests pass.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.