Skip to content

.clang-format and .pre-commit#261

Merged
pelesh merged 15 commits intodevelopfrom
nicholson/pre-commit
Jun 19, 2025
Merged

.clang-format and .pre-commit#261
pelesh merged 15 commits intodevelopfrom
nicholson/pre-commit

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Apr 24, 2025

Description

Code formatting configuration files with CI support to apply the changes.
To replace PRs #82 and #151.
Addresses issues #5, #54 and #150.

Proposed changes

Added clang-format and pre-commit files.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • All tests pass. Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

Currently not applying the pre-commit changes. This is first to test the pipeline.

@nkoukpaizan nkoukpaizan self-assigned this Apr 24, 2025
@pelesh pelesh self-requested a review April 26, 2025 02:59
@pelesh pelesh added the enhancement New feature or request label Apr 26, 2025
@pelesh pelesh added this to the Release 0.99.2 milestone Apr 26, 2025
@superwhiskers
Copy link
Collaborator

my only comment is that to completely supplant #151, you should also delete these lines from CMakeLists.txt.

@pelesh pelesh force-pushed the nicholson/pre-commit branch from 3122d10 to ff8769a Compare June 18, 2025 20:59
@pelesh pelesh marked this pull request as ready for review June 18, 2025 21:21
@pelesh pelesh merged commit f096546 into develop Jun 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants