-
Notifications
You must be signed in to change notification settings - Fork 7
Add cmake doxygen target and remove unused files #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nkoukpaizan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I was able to build the target locally (make GridKitDocs) and look at the documentation.
Some things need fixing in the documented code, but that's out of scope for this PR.
@PhilipFackler could you elaborate on why this is a superior approach? Perhaps a README file in docs/ could document this and provide instructions for building?
The |
I'm not 100% sure I understand the question, but here are my thoughts:
I get that this is partly a matter of preference. |
Yes, that answers my question. I want us to keep a record of these choices. Also, the reason I'm asking to document the build is that |
|
@nkoukpaizan I added |
Description
Add a doxygen target (
make GridKitDocs) to CMakeProposed changes
Use CMake's FindDoxygen module to create a doxygen target with custom options set in docs/CMakeLists.txt. This makes maintenance easier since we only customize a handful of options.
NOTE: I removed the top-level
Doxyfileandmainpage.doxbecause it seemed like they weren't actually used for anything.Checklist
-Wall -Wpedantic -Wconversion -Wextra.