Encapsulate nlohmann/json and magic_enum as implementation details#294
Merged
Encapsulate nlohmann/json and magic_enum as implementation details#294
nlohmann/json and magic_enum as implementation details#294Conversation
516d449 to
13bb725
Compare
13bb725 to
2d75d02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These two third-party libraries don't need to be exposed to the user
Relates to #278
Needed for #253
Proposed changes
Introduce a simple function
parseSystemModelData(which can takestd::istream,std::filesystem::path, orstd::string) to generate aSystemModelData<double, size_t>object from JSON input.Checklist
-Wall -Wpedantic -Wconversion -Wextra.