Skip to content

Encapsulate nlohmann/json and magic_enum as implementation details#294

Merged
pelesh merged 1 commit intodevelopfrom
PhilipFackler/wrap-tpls
Oct 30, 2025
Merged

Encapsulate nlohmann/json and magic_enum as implementation details#294
pelesh merged 1 commit intodevelopfrom
PhilipFackler/wrap-tpls

Conversation

@PhilipFackler
Copy link
Collaborator

@PhilipFackler PhilipFackler commented Oct 29, 2025

Description

These two third-party libraries don't need to be exposed to the user

Relates to #278
Needed for #253

Proposed changes

Introduce a simple function parseSystemModelData (which can take std::istream, std::filesystem::path, or std::string) to generate a SystemModelData<double, size_t> object from JSON input.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@PhilipFackler PhilipFackler requested review from nkoukpaizan and pelesh and removed request for nkoukpaizan October 29, 2025 20:31
@PhilipFackler PhilipFackler added enhancement New feature or request development Features/Tools related to development of GridKit, rather than use as a library. cmake labels Oct 29, 2025
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/wrap-tpls branch from 516d449 to 13bb725 Compare October 29, 2025 20:34
@PhilipFackler PhilipFackler mentioned this pull request Oct 29, 2025
7 tasks
@pelesh pelesh requested a review from superwhiskers October 29, 2025 21:54
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pelesh pelesh merged commit aba33f7 into develop Oct 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake development Features/Tools related to development of GridKit, rather than use as a library. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants