Conversation
nkoukpaizan
changed the base branch from
develop
to
nicholson/external-var-Jacobian
nkoukpaizan
force-pushed
the
nicholson/test-Genrou-locally
branch
from
deee4a5 to
2d6fccf
Compare
Collaborator
|
@nkoukpaizan is this ready for review and (eventually) merge? This is still a draft PR. |
Collaborator
Author
|
Sure, it can be reviewed. I just need to remind myself to point to an Enzyme release. |
Collaborator
|
Perhaps we want to update GridKit spack and README now that @wsmoses merged |
nkoukpaizan
force-pushed
the
nicholson/test-Genrou-locally
branch
from
34a5984 to
0d3dd89
Compare
nkoukpaizan
changed the base branch from
nicholson/external-var-Jacobian
to
develop
pelesh
approved these changes
Oct 30, 2025
Collaborator
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
I think this is ready to merge.
nkoukpaizan
force-pushed
the
nicholson/test-Genrou-locally
branch
from
0d3dd89 to
d03bc25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This re-activates
GenrouEnzymebuilds and related tests, as the underlying issue in Enzyme has been addressed.Closes #234
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Waiting for the bug fix to be in an Enzyme release to merge.