Add identity recognition protocol support#50
Open
josephabbey wants to merge 3 commits intoOHF-Voice:mainfrom
Open
Add identity recognition protocol support#50josephabbey wants to merge 3 commits intoOHF-Voice:mainfrom
josephabbey wants to merge 3 commits intoOHF-Voice:mainfrom
Conversation
- Add identity events and info schema - Document identity recognition support - Cover new event and info types in tests
- Support enroll and delete request/response events - Update docs, changelog, and event tests
Author
|
This is still in it's initial stages, but I would like some input on what others think about the flow for enrolling new identities. My second commit there adds support for enrolling via wyoming, but it may be better for enrolling to happen via a web gui that is provided by the App. The benefit to including it in wyoming is that HomeAssistant can provide an interface to enroll voices per user. |
Author
|
I'll also need to make some better thought out tests. |
- Add `identity` pipeline stage and state - Carry `identity_name` through run-pipeline events - Update docs and tests for new stage ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new service to the protocol:
identity.This service should run at the same time as
asrand provide the context of who is talking to the intent parser and handler. This will allow for per user aliases (e.g. "My bedside light"), and tentatively permission handling.My current thoughts on the concurrency is: Home Assistant will call this service asynchronously next to the
asrand this will be handled outside of the standard pipeline order.