Open
Conversation
* Initial plan * Add py.typed to package-data in pyproject.toml Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR adds PEP 561 compliance to the home_assistant_intents package by introducing a py.typed marker file. This allows type checkers like mypy and pyright to recognize and validate the type hints in this package when it's used as a dependency by other projects, such as Home Assistant's conversation component.
Changes:
- Added empty
py.typedmarker file to thehome_assistant_intentspackage root - Updated
pyproject.tomlto includepy.typedin the package-data configuration for distribution
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
home_assistant_intents/py.typed |
Empty PEP 561 marker file indicating the package contains type hints |
pyproject.toml |
Added py.typed to the package-data list to ensure it's included in distributions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
A py.typed file is a marker file required by PEP 561, placed in a Python package's root directory to indicate to type checkers (like mypy or pyright) that the package contains type hints. It is needed to enforce strict typing for
homeassistant.components.conversation.Best regards,
Kamil