[16.0][ADD/IMP] stock_release_channel_shipment_advice*: Add buttons on release channel kanban to print shipments, delivery slip and cash on delivery invoices

[tuantrantg]

This PR includes:

• [IMP] stock_release_channel_shipment_advice: Add buttons on release channel kanban to print shipments and delivery slip
• [ADD] stock_release_channel_shipment_advice_print_cash_on_delivery: Add buttons on release channel kanban to print cash on delivery invoices

Depends on:

• [16.0][IMP/ADD] shipment_advice*: Add action on shipment advice to print delivery slip and cash on delivery invoices stock-logistics-transport#129
• [16.0][ADD] partner_invoicing_mode_cash_on_delivery account-invoicing#1736
• [IMP] partner_invoicing_mode_at_shipping: Add grouping option per picking account-invoicing#1628
• [16.0][IMP] partner_invoicing_mode: Allow better inheritance + use correctly grouping option account-invoicing#1515

[OCA-git-bot]

Hi @jbaudoux,
some modules you are maintaining are being modified, check this out!

[jbaudoux]

ping @rousseldenis @lmignon

[jbaudoux]

Implement is_action_print_shipment_allowed as this:

• In stock_release_channel: If state == "locked" and shipment_advice_to_print_ids
  • where you define shipment_advice_to_print_ids as last(rec.shipment_advice_ids.filtered(state == done))
• In stock_release_channel_deliver: if not "auto_deliver", then super() else:
  if state == "delivered" and shipment_advice_to_print_ids
  • where you define shipment_advice_to_print_ids as if not "auto_deliver", then super() else rec.in_release_channel_auto_process.filtered(state == done)

Note: have to add auto_deliver on release channel in module stock_release_channel_deliver (#819)

[cyrilmanuel]

@tuantrantg little ping, could you take care of this pr ?

[tuantrantg]

@tuantrantg little ping, could you take care of this pr ?

I'm a little busy right now, so I'll come back soon to take care of this

[tuantrantg]

hi @jbaudoux could you please clarify these points:

where you define shipment_advice_to_print_ids as last(rec.shipment_advice_ids.filtered(state == done))

--> last(rec.shipment_advice_ids.filtered(state == done)): you mean the last done record in shipment_advice_ids, don't you?

where you define shipment_advice_to_print_ids as if not "auto_deliver", then super() else rec.in_release_channel_auto_process.filtered(state == done)

--> in_release_channel_auto_process is a boolean field, could you please recheck this point

[jbaudoux]

hi @jbaudoux could you please clarify these points:

where you define shipment_advice_to_print_ids as last(rec.shipment_advice_ids.filtered(state == done))

--> last(rec.shipment_advice_ids.filtered(state == done)): you mean the last done record in shipment_advice_ids, don't you?

Yes :)
In stock_release_channel_shipment_advice module
Just to implement a simple solution

where you define shipment_advice_to_print_ids as if not "auto_deliver", then super() else rec.in_release_channel_auto_process.filtered(state == done)

--> in_release_channel_auto_process is a boolean field, could you please recheck this point

Sorry it is in_process_shipment_advice_ids which computes based on in_release_channel_auto_process
In stock_release_channel_shipment_advice_deliver module

[tuantrantg]

Implement is_action_print_shipment_allowed as this:

• In stock_release_channel: If state == "locked" and shipment_advice_to_print_ids

  • where you define shipment_advice_to_print_ids as last(rec.shipment_advice_ids.filtered(state == done))

• In stock_release_channel_deliver: if not "auto_deliver", then super() else:
  if state == "delivered" and shipment_advice_to_print_ids

  • where you define shipment_advice_to_print_ids as if not "auto_deliver", then super() else rec.in_release_channel_auto_process.filtered(state == done)

Note: have to add auto_deliver on release channel in module stock_release_channel_deliver (#819)

hi @jbaudoux please review this PR and jbaudoux#5 also

[jbaudoux]

LG, thanks

[jbaudoux]

@rousseldenis @lmignon Release channel printing module ported to OCA, as well as cash on delivery

[jbaudoux]

@tuantrantg Don't merge 16.0 branch in your PR but use instead rebase

[jbaudoux]

@dreispt It doesn't need fixing. It's waiting for dependencies to be merged

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[cyrilmanuel]

hi @tuantrantg could you rebase this pr with this dependency : OCA/account-invoicing#2288 superseed of OCA/account-invoicing#1736 ?

[cyrilmanuel]

superseed here : #1147