[16.0][FIX] shopfloor_reception: make sure "set_lot" is skipped on existing lot scan#1157
Draft
nicolas-delbovier-acsone wants to merge 29 commits intoOCA:16.0from
Draft
Conversation
…er readibility Reorganized the template structure to ensure the date-picker is positioned adjacent to its related components inside the "set_lot" template.
- Merge `set_lot_confirm_action` and `set_lot` endpoints so as to call only one endpoint - Ensures lot is not created in DB until proven valid - Add expired expiration date check
Update the 'set_lot' state logic to store user input locally on the active move line before calling the backend. Crucially, this ensures the 'set_lot' function is now called with both 'expiration_date' and 'lot_name' at the same time upon confirmation. This prevents premature backend calls with partial data and allows for better validation of the lot on the server.
Updated unit tests to be resistant to changes in product data serialization. Previously, tests used a hard-coded dict, which caused failures when other modules modified the product's serialized fields.
Add an endpoint to call on lot name scan. This enables to detect already existing lots. This endpoint could also be used to add logic to extract extra infos from barcode such as expiration date.
…t name scan Refactoring ideas in: OCA@3469638 and OCA@c5f931b
When a user provides a lot name but forgets the expiration date, the `lot_name` was previously lost in the response. This change ensures that `lot_name` is included in the returned data, allowing the UI to retain the value and preventing the user from having to re-type it.
The frontend was sending expiration dates in the user's local timezone. Because Odoo expects datetime values in UTC, this caused "hour shifts" that could move the expiration date to the previous day in the database. This fix ensures that the selected date is treated as local midnight and converted to the corresponding UTC timestamp before being sent to the server.
…display Updated the lot expiration display to show only the date component. Since the selection widget is restricted to dates, displaying the time was redundant.
…trings - Rename internal methods to follow standard naming conventions, ensuring compatibility for downstream modules inheriting from this component. - Updated docstrings to accurately reflect method behavior.
…iration date on a lot
The 'UTC=timezone.utc' alias was introduced in Python 3.11. To maintain support for environments running Python 3.10, the alias is added manually at the beginning of the file
Enforce the 'use_create_lots' setting from the picking type during the reception process.
… screen The logic for the cancel action was defined, but the event listener was missing from the button template.
When a lot name is present on the move line, the system now attempts to find a matching existing lot record. If found, the lot metadata is sent to the frontend to pre-fill the screen, preventing redundant data entry.
Update '_response_for_set_lot' to check if lot information was already resolved during parsing. If the parsed data is complete, the system now bypasses the 'set_lot' entry screen and processes the confirmation automatically.
…ction` Break down the function into smaller functions to isolate responsability and make code more readable
Contributor
|
Hi @sebalix, @simahawk, @guewen, @mmequignon, @JuMiSanAr, |
OCA-git-bot
added
series:16.0
mod:shopfloor
nicolas-delbovier-acsone
changed the title
nicolas-delbovier-acsone
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on: #1128