[16.0][IMP] shopfloor_reception*: allow over receiving by nicolas-delbovier-acsone · Pull Request #1090 · OCA/wms

nicolas-delbovier-acsone · 2025-08-12T14:56:29Z

This PR adds the possibility to receive more goods than ordered (in case of an error from the supplier for example)

OCA-git-bot · 2025-08-12T14:56:34Z

Hi @simahawk, @JuMiSanAr, @guewen, @mmequignon, @sebalix,
some modules you are maintaining are being modified, check this out!

sbejaoui · 2025-08-13T21:22:33Z

+        if compare == 1 and not is_over_reception_confirmed:
+            line.write(previous_vals)
+            message = self._response_for_confirm_over_reception(
+                picking,
+                line,
+                quantity,
+                action,
+                message=self.msg_store.line_scanned_qty_done_higher_than_allowed(),


avoid the useless write,

if compare == 1: return self._response_for_confirm_over_reception() line.qty_done = quantity

This write is not useless, this is used to rollback the value before user confirms.

I need to do this because the function _set_quantity__check_quantity_done is checking all the qty_done on the move so I need to update the move before this check but then I need to rollback before user confirms. I agree this is not beautiful since, in the case of a user confirming, we will have a useless double write. However, I suspect this is necessary to follow this pattern to avoid problems in the case of many workers working on the same move.

I copied this pattern from the function _set_quantity__by_product

sbejaoui · 2025-08-13T21:31:26Z

+    # def over_reception_ask_confirm(self):
+    #     return {
+    #         "message_type": "warning",
+    #         "body": _(
+    #             "You confirmed you wanted to receive more goods "
+    #             "than expected. Click again to continue."
+    #         ),
+    #     }
+


Suggested change

# def over_reception_ask_confirm(self):

# return {

# "message_type": "warning",

# "body": _(

# "You confirmed you wanted to receive more goods "

# "than expected. Click again to continue."

# ),

# }

sbejaoui · 2025-08-13T21:31:38Z

            "message_type": "warning",
            "body": _(
-                "Confirm location change from %(location_from)s to " "%(location_to)s?"
+                "Confirm location change from %(location_from)s to %(location_to)s?"


avoid this changes

sbejaoui · 2025-08-13T21:31:56Z

            }
            if (this.qty > this.qtyTodo) {
-                return "background-color: orangered";
+                return "background-color: rgb(229, 171, 0)";


avoid this changes

The idea was to make the color a "warning" color instead of a "danger" one since now it is possible to over-receive. Thus, it is no more an error.

sbejaoui · 2025-08-13T21:33:59Z

+        """
+
+    def _set_quantity__process__set_qty_and_split(
+        self, picking, line, quantity, action, is_over_reception_confirmed=False


Suggested change

self, picking, line, quantity, action, is_over_reception_confirmed=False

self, picking, line, quantity, action=None, is_over_reception_confirmed=False

sbejaoui · 2025-08-14T13:18:44Z

                return response
-            compare = self._set_quantity__check_quantity_done(selected_line)
+            compare = self._set_quantity__check_quantity_done(
+                selected_line, selected_line.qty_done


Suggested change

selected_line, selected_line.qty_done

selected_line, sum(move.move_line_ids.mapped("qty_done"))

sbejaoui

Code review + functional test

simahawk

Can we have separated commits per module? The rest can be squashed.

simahawk · 2025-08-20T08:53:47Z

@@ -1,7 +1,3 @@
-.. image:: https://odoo-community.org/readme-banner-image


Could you please rollback these README changes?
TIP: run export SKIP=oca-gen-addon-readme to avoid updating readme files on each commit ;)

simahawk · 2025-08-20T08:57:48Z

-            savepoint.rollback()
-            return self._response_for_set_quantity(
-                picking, line, message=self.msg_store.unable_to_pick_qty()
+    def _after_over_recepetion_confirmed_hook(self, picking, line):


Suggested change

def _after_over_recepetion_confirmed_hook(self, picking, line):

def _after_over_reception_confirmed_hook(self, picking, line):

simahawk · 2025-08-20T08:59:43Z

+            "process_with_new_pack",
+            is_over_reception_confirmed,


Suggested change

"process_with_new_pack",

is_over_reception_confirmed,

action="process_with_new_pack",

is_over_reception_confirmed=is_over_reception_confirmed,

I'm not a fan of "hiding" kw args w/ positional args just because python allows to do so :)

simahawk · 2025-08-20T09:03:04Z

+                <div class="button-list button-vertical-list full">
+                    <v-row align="center">
+                        <v-col class="text-center" cols="12">
+                            <div>{{ state.display_info.message }}</div>


display_info messages are normally visible on the top of the page automatically. Is this really needed?

github-actions · 2025-12-21T12:15:49Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

sbejaoui · 2026-02-19T15:40:31Z

can you rebase please

nicolas-delbovier-acsone force-pushed the 16.0-imp-shopfloor-reception-allow-over-receiving-nde branch from 8e064b8 to 462d83d Compare August 12, 2025 15:03

sbejaoui requested changes Aug 13, 2025

View reviewed changes

Comment thread shopfloor_reception/tests/test_set_quantity.py

nicolas-delbovier-acsone force-pushed the 16.0-imp-shopfloor-reception-allow-over-receiving-nde branch from 7ffe855 to 6704bf5 Compare August 14, 2025 07:02

sbejaoui requested changes Aug 14, 2025

View reviewed changes

sbejaoui approved these changes Aug 18, 2025

View reviewed changes

simahawk changed the title ~~[16.0][IMP] shopfloor reception: allow over receiving~~ [16.0][IMP] shopfloor_reception*: allow over receiving Aug 20, 2025

simahawk requested changes Aug 20, 2025

View reviewed changes

jbaudoux mentioned this pull request Sep 22, 2025

Shopfloor reception - missing features #1018

Open

27 tasks

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 21, 2025

nicolas-delbovier-acsone force-pushed the 16.0-imp-shopfloor-reception-allow-over-receiving-nde branch from 9155440 to 3b31d93 Compare January 23, 2026 16:04

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 25, 2026

nicolas-delbovier-acsone added 2 commits February 20, 2026 15:13

[IMP] shopfloor_reception: Allow over-receiving in reception scenarios

9963922

[IMP] shopfloor_reception_mobile: allow over-receiving

fde4d5a

nicolas-delbovier-acsone force-pushed the 16.0-imp-shopfloor-reception-allow-over-receiving-nde branch from 3b31d93 to fde4d5a Compare February 20, 2026 14:14

	self, picking, line, quantity, action, is_over_reception_confirmed=False
	self, picking, line, quantity, action=None, is_over_reception_confirmed=False

	selected_line, selected_line.qty_done
	selected_line, sum(move.move_line_ids.mapped("qty_done"))

		@@ -1,7 +1,3 @@
		.. image:: https://odoo-community.org/readme-banner-image

	def _after_over_recepetion_confirmed_hook(self, picking, line):
	def _after_over_reception_confirmed_hook(self, picking, line):

Uh oh!

Conversation

nicolas-delbovier-acsone commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Aug 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolas-delbovier-acsone Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbejaoui left a comment

Choose a reason for hiding this comment

Uh oh!

simahawk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 21, 2025

Uh oh!

sbejaoui commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nicolas-delbovier-acsone commented Aug 12, 2025 •

edited

Loading

nicolas-delbovier-acsone Aug 14, 2025 •

edited

Loading