[FIX] web_domain_field: Accept empty domain #3403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirPyTech
force-pushed
the
14.0-fix-web_domain_field-default_empty_domain
branch
from
55eaecd to
4c0bd76
Compare
Steps: 1. Create a domain field that contains `False` 2. Associate the created field to a relational field 3. In a form view, open the dropdown of the filtered relational field Before this change: The following client error is raised: > Error: second argument to Function.prototype.apply must be an array eval_domains/<@https://domain.com/web_domain_field/static/lib/js/pyeval.js:156:40 [...] After this change: All the records can be selected
SirPyTech
force-pushed
the
14.0-fix-web_domain_field-default_empty_domain
branch
from
4c0bd76 to
1ee5763
Compare
jappi00
reviewed
Jan 25, 2026
Contributor
jappi00
left a comment
jappi00
left a comment
There was a problem hiding this comment.
Small nitpick but functional and code looks good.
| margin-left: 2em ; | ||
| margin-right: 2em } | ||
|
|
||
| pre.code .ln { color: grey; } /* line numbers */ |
Contributor
There was a problem hiding this comment.
nitpick: css supports both: american an english. I think we do not need a change here?
Author
There was a problem hiding this comment.
Good catch!
This change was done automatically by pre-commit so I'd leave it as it is right now.
I think it was somehow generated by https://github.com/OCA/maintainer-tools/blob/71aa4caec15e8c1456b4da19e9f39aa0aa7377a9/tools/gen_addon_readme.py but I can't find where, it is probably some change in some dependency.
jappi00
approved these changes
Jan 25, 2026
Contributor
jappi00
left a comment
jappi00
left a comment
There was a problem hiding this comment.
didn't click on approve before. Sorry.
Contributor
|
@OCA/web-maintainers can this be merged? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps:
FalseBefore this change:
The following client error is raised:
After this change:
All the records can be selected
Additional context:
Fixes #882 that is closed because stale, not because it is fixed.
I struggled to add a test that fails without this change (as the UI does), but failed: the added test succeeds without this change too.If anyone can help make the test fail without this change, it is much appreciated! Otherwise, at least we have added a test to the module.
The added test fails without this change.
For anyone who is interested:
clicking on the dropdown does not open it, butclicking on the field label does.