[16.0][FIX] stock_picking_volume: volume not computed on record creation #2517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Volume field was not computed when creating pickings/moves from the UI
- Root cause: `readonly=False` on a stored computed field causes the ORM to treat
the explicit `0` sent by the web client as a manual override, skipping recompute
- Removed `readonly=False` and `states` from Python field definitions
- Moved readonly logic to XML views via `attrs` (editable in draft, readonly in done/cancel)
Contributor
|
Hi @lmignon, |
|
LGTM |
dreispt
approved these changes
Feb 10, 2026
lmignon
suggested changes
Feb 11, 2026
|
|
||
| volume = fields.Float( | ||
| compute="_compute_volume", | ||
| readonly=False, |
Contributor
There was a problem hiding this comment.
This one should remain readonly=False also on the python side otherwise it's no more possible to manually assign a value.
Contributor
There was a problem hiding this comment.
I wonder if the fix to the problem would be to simply declare the field as precompute=True 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readonly=Falseon a stored computed field causes the ORM to treat the explicit0sent by the web client as a manual override, skipping recomputereadonly=Falseandstatesfrom Python field definitionsattrs(editable in draft, readonly in done/cancel)