[ADD] mass_mailing_list_prune_blacklisted#1853
Open
Conversation
OCA-git-bot
added
mod:mass_mailing_list_prune_blacklisted
SirPyTech
force-pushed
the
16.0-add-mass_mailing_list_cleanup
branch
from
0ff03a9 to
266e35d
Compare
quirino95
approved these changes
Apr 17, 2026
quirino95
left a comment
quirino95
left a comment
There was a problem hiding this comment.
Code review: LGTM.
Functional review: find a non-blocking issue. I've already approved but if you could, I'd like you to improve this thing:
When selecting a mailing list, I need to save before button "Prune lists" appears.
As consequence, if an user click on "SEND" button directly, won't never see "Prune lists".
Would it be possible to make the button appear when you choose the mailing list instead of waiting for the save?
| Blacklisted contacts can be removed while creating a new mailing: | ||
|
|
||
| 1. Create a new mailing | ||
| 2. Select a miling list that contains blacklisted contacts: a button "Prune lists..." appears |
There was a problem hiding this comment.
Chore (non blocking): small typo here
Suggested change
| 2. Select a miling list that contains blacklisted contacts: a button "Prune lists..." appears | |
| 2. Select a mailing list that contains blacklisted contacts: a button "Prune lists..." appears |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to massively remove blacklisted contacts from mailing lists.