[18.0][IMP] sign_oca: Add guided arrow flow to sign_oca#80
[18.0][IMP] sign_oca: Add guided arrow flow to sign_oca#80kobros-tech wants to merge 3 commits intoOCA:18.0from
Conversation
|
Hi @etobella, |
kobros-tech
force-pushed
the
18.0-imp-sign_oca-3
branch
from
28cbd7b to
372f066
Compare
kobros-tech
force-pushed
the
18.0-imp-sign_oca-3
branch
2 times, most recently
from
324f59f to
ab74e88
Compare
|
This is how the arrow should look like:
|
|
A simple preliminary description video: |
etobella
left a comment
etobella
left a comment
There was a problem hiding this comment.
You left a lot of console logs and comments to your name that don't have sense. Please remove them and add some comments on the functions explaining the goal of each one. I don't understand why you need to remove them from the core file if they are only used on a single place....
| * @param { Environment } env | ||
| */ | ||
| export function startSignItemNavigator(parent, target, types, env) { | ||
| console.log("types", types); |
sign_oca/static/src/components/sign_oca_pdf_common/sign_oca_navigator.esm.js
Outdated
Show resolved
Hide resolved
sign_oca/static/src/components/sign_oca_pdf_common/sign_oca_navigator.esm.js
Outdated
Show resolved
Hide resolved
kobros-tech
force-pushed
the
18.0-imp-sign_oca-3
branch
from
e004307 to
0610fe5
Compare
|
Why are the changes of #78 also added here? I don't understand it. |
|
hi all this module is under development, so if we can cooperate in the main important cause of it is more effective. Once it is working as expected all normal procedures will be done. Thanks all |
etobella
changed the title
kobros-tech
force-pushed
the
18.0-imp-sign_oca-3
branch
6 times, most recently
from
0a044ca to
f0dbb2e
Compare
kobros-tech
force-pushed
the
18.0-imp-sign_oca-3
branch
from
f0dbb2e to
633eb06
Compare
|
@dnplkndll I enabled auto check of the checkbox, the default is when it is selected you can press on space button to check or un check it. The module is ready for review for all its fields fillings. Screencast.2025-02-09.06.22.08.mp4 |
kobros-tech
changed the title
|
The solution is to reprepare fields to follow and to make sure that the navigator div is created ONLY once. |
kobros-tech
force-pushed
the
18.0-imp-sign_oca-3
branch
from
f2f25ed to
a3524db
Compare
|
there is a bug with the original module which is: if someone fills all required fields and then clear one field the validate button still clickable, even after validation error if the partner fills the fields the validation button is still not clickable. We have to check it after filling each field value. |
|
@etobella |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
5 participants
add arrow / guided flow to sign_oca
#88