[18.0][MIG] sign_oca: Migration to 18.0 by kobros-tech · Pull Request #74 · OCA/sign

kobros-tech · 2024-12-28T10:59:50Z

@rvalyi
@ovnicraft
@azmeuk
@pniederlag
@cmayo

I need reviewing sign_oca for 18.0

[BOT] post-merge updates

[UPD] Update sign_oca.pot

Translated using Weblate (Italian) Currently translated at 28.2% (48 of 170 strings) Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/ Translated using Weblate (Italian) Currently translated at 100.0% (170 of 170 strings) Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/

[UPD] Update sign_oca.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/

Currently translated at 100.0% (170 of 170 strings) Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/ Translated using Weblate (Italian) Currently translated at 100.0% (170 of 170 strings) Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/

TT41745

[UPD] Update sign_oca.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/

1. Add Sign button in request form (it was only in tree view). 2. Fix configure template action when it is created from a request.

TT41745

… any user access to sign page TT41745

TT41745

…expression) TT41745

TT41745

- Load 'required' field in configure dialog - Show 'required' fields in red in configure mode - Load 'role_id' field in configure dialog

Unify to_sign and signer_is_allow_signature fields which had the same purpose

kobros-tech · 2025-01-09T17:02:59Z

Thanks, it's almost ready, the name (similar to v17) is missing. v17

v18

@victoralmau

ok, I am using now the same old code for this part, it is my final destination :)

kobros-tech · 2025-01-09T17:15:48Z

@victoralmau
I need you to approve if it is ok

victoralmau · 2025-01-10T07:14:35Z

#74 (comment) is pending.

kobros-tech · 2025-01-10T09:22:25Z

#74 (comment) is pending.

@victoralmau
I assure your opinion is not valid for version 18.0 and we have to call the ID by ourselves.

If you find this code in odoo repository for v18.0 I will follow along.

victoralmau · 2025-01-10T09:57:10Z

An example of odoo using user is https://github.com/odoo/odoo/blob/18.0/addons/calendar/static/src/views/attendee_calendar/attendee_calendar_model.js#L24.

kobros-tech · 2025-01-10T11:27:44Z

An example of odoo using user is https://github.com/odoo/odoo/blob/18.0/addons/calendar/static/src/views/attendee_calendar/attendee_calendar_model.js#L24.

all right thanks for being active with me, I will check it by Sunday and try to follow along

kobros-tech · 2025-01-11T20:37:56Z

Hi @victoralmau
thanks for the link, with this procedure We use current user id
it is now inside user object, so we will be importing & using user object instead of session object

pedrobaeza · 2025-01-13T07:50:09Z

/ocabot migration sign_oca
/ocabot merge nobump

OCA-git-bot · 2025-01-13T08:58:06Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

etobella · 2025-01-13T09:56:51Z

/ocabot merge nobump
Ocabot didn't launch the merge 😭

OCA-git-bot · 2025-01-13T09:57:01Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-74-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2025-01-13T10:01:29Z

Congratulations, your PR was merged at 664bf85. Thanks a lot for contributing to OCA. ❤️

pedrobaeza · 2025-01-13T10:37:24Z

/ocabot migration sign_oca

kobros-tech · 2025-01-13T13:09:07Z

/ocabot migration sign_oca

@pedrobaeza

We are planning to create a new module in this project.

Could you guide me on the steps and rules to follow to make it efficient and successful?

pedrobaeza · 2025-01-13T13:31:16Z

You just need to do a pull request with the new module. pre-commit will highlight the linter things and the CI any possible error.

etobella and others added 30 commits December 26, 2024 15:07

[ADD] sign_oca

49394d2

[FIX] sign_oca: wizard_id comodel

200b72d

[BOT] post-merge updates

[FIX] sign_oca: black, isort, prettier

7f49e3e

[MIG] sign_oca: Migration to 16.0

fd2b739

[UPD] Update sign_oca.pot

[FIX] sign_oca: Add description sign.oca.request.log

7178a56

[FIX] sign_oca: Add configure action to sign.oca.request.log

4cf09de

TT41745

[FIX] sign_oca: Add filename file to show binary correctly in UX

bb08815

TT41745

[FIX] sign_oca: Some fixes

2fe3986

1. Add Sign button in request form (it was only in tree view). 2. Fix configure template action when it is created from a request.

[IMP] sign_oca: preview requests

d1b233a

[IMP] sign_oca: Improve README

de4709c

TT41745

[IMP] sign_oca: Update .pot file

bc0ac30

TT41745

[IMP] sign_oca: Add Administrator group + improve ACLs + add rules

3b319d5

TT41745

[FIX] sign_oca: Add authenticate() method to test_portal

9ad6b97

TT41745

[IMP] sign_oca: Add record_ref to requests

080d161

TT41745

[IMP] sign_oca: Add _description to sign.oca.request.log

f16df23

TT41745

[IMP] sign_oca: Add systray compatibility

f6e6e3b

TT41745

[IMP] sign_oca: Add sign button to sign.oca.request + signer to allow…

11ff117

… any user access to sign page TT41745

[IMP] sign_oca: Add model_id to templates

f7cc2e2

TT41745

[IMP] sign_oca: Improve roles to set partner type (empty, default or …

50391bf

…expression) TT41745

[IMP] sign_oca: Add Wizard Generate Multi

c934a90

TT41745

[IMP] sign_oca: Link from partner to signer

44e354d

[IMP] sign_oca: Add Sign from template action from tree and form view

c7e3547

TT41745

[FIX] sign_oca: Small fixes in configure mode

2af0d66

- Load 'required' field in configure dialog - Show 'required' fields in red in configure mode - Load 'role_id' field in configure dialog

[IMP] sign_oca: Add groups in partner link to request

df9adc7

[FIX] sign_oca: Duplicated Sign button in request

15d93be

Unify to_sign and signer_is_allow_signature fields which had the same purpose

[FIX] sign_oca: Remove legacy code and rename fields

c80fd35

kobros-tech force-pushed the 18.0-mig-sign_oca branch from 3953e60 to 75b6bdb Compare January 9, 2025 17:01

kobros-tech requested a review from victoralmau January 9, 2025 17:15

kobros-tech force-pushed the 18.0-mig-sign_oca branch from 75b6bdb to 1c55ec1 Compare January 11, 2025 20:34

[18.0][MIG] sign_oca: Migration to 18.0

d4ca2a3

kobros-tech force-pushed the 18.0-mig-sign_oca branch from 1c55ec1 to d4ca2a3 Compare January 12, 2025 11:46

victoralmau approved these changes Jan 13, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 13, 2025

OCA-git-bot added the ready to merge label Jan 13, 2025

etobella approved these changes Jan 13, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 13, 2025

OCA-git-bot merged commit 4d4c489 into OCA:18.0 Jan 13, 2025
6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 13, 2025

OCA-git-bot added this to the 18.0 milestone Jan 13, 2025

OCA-git-bot mentioned this pull request Jan 13, 2025

Migration to version 18.0 #67

Closed

3 tasks

Uh oh!

Conversation

kobros-tech commented Dec 28, 2024

Uh oh!

kobros-tech commented Jan 9, 2025

Uh oh!

kobros-tech commented Jan 9, 2025

Uh oh!

victoralmau commented Jan 10, 2025

Uh oh!

kobros-tech commented Jan 10, 2025

Uh oh!

victoralmau commented Jan 10, 2025

Uh oh!

kobros-tech commented Jan 10, 2025

Uh oh!

kobros-tech commented Jan 11, 2025

Uh oh!

pedrobaeza commented Jan 13, 2025

Uh oh!

OCA-git-bot commented Jan 13, 2025

Uh oh!

etobella commented Jan 13, 2025

Uh oh!

OCA-git-bot commented Jan 13, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Jan 13, 2025

Uh oh!

pedrobaeza commented Jan 13, 2025

Uh oh!

kobros-tech commented Jan 13, 2025

Uh oh!

pedrobaeza commented Jan 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants