[19.0][MIG] base_view_inheritance_extension: Migration to 19.0 by bizzappdev · Pull Request #3382 · OCA/server-tools

bizzappdev · 2025-09-22T09:18:46Z

No description provided.

Reyes4711-S73

LGTM

eugenios73

LGFM

yankinmax · 2025-11-21T13:17:01Z

Hello @bizzappdev I've a traceback on one of another migrations related to this module.
Can you pls take a look and update this PR:
https://github.com/OCA/operating-unit/actions/runs/19571555294/job/56046065076?pr=818#step:7:653

Traceback (most recent call last):
  ...
  File "/opt/odoo/odoo/addons/base/models/ir_ui_view.py", line 1027, in _combine
    combined_arch = view.apply_inheritance_specs(combined_arch, arch)
  File "/opt/odoo-venv/lib/python3.10/site-packages/odoo/addons/base_view_inheritance_extension/models/ir_ui_view.py", line 58, in apply_inheritance_specs
    source = handled_by(source, specs)
  File "/opt/odoo-venv/lib/python3.10/site-packages/odoo/addons/base_view_inheritance_extension/models/ir_ui_view.py", line 113, in _inheritance_handler_attributes_update
    node_attr = (node.get(attr_name) or "{}").strip()
AttributeError: 'NoneType' object has no attribute 'get'

Maybe just a check if a node exist?

alexis-via · 2025-12-10T11:06:55Z

@bizzappdev what does the "-BAD" suffix mean in your branch name ??

alexis-via · 2025-12-10T11:12:54Z

base_view_inheritance_extension/__manifest__.py

+    "summary": "Adds more operators for view inheritance",
+    "website": "https://github.com/OCA/server-tools",
+    "depends": ["base"],
+    "external_dependencies": {"python": ["astor"]},


astor is not used in the code, so it can be removed

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

expression not match the node any more. Fixes OCA#885

* warning about dynamic context * import for safe_eval

Use https in URL to licence

…d list_remove

remove loggin

[MIG] base_view_inheritance_extension: Migration to 18.0 Co-authored-by: Lukas Tran <nhant@trobz.com>

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_view_inheritance_extension/

…hile using ast.Str.

Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-18.0/server-tools-18.0-base_view_inheritance_extension Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_view_inheritance_extension/nl/

Drops ``astor``: unused external dependency

AaronHForgeFlow

It works, so only pending to attend current open comments.

OCA-git-bot · 2025-12-12T15:39:53Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

StefanRijnhart · 2025-12-17T09:15:54Z

@bizzappdev did you address the error 'AttributeError: 'NoneType' object has no attribute 'get'' mentioned in #3382 (comment) already?

yankinmax · 2025-12-17T09:19:41Z

@bizzappdev did you address the error 'AttributeError: 'NoneType' object has no attribute 'get'' mentioned in #3382 (comment) already?

We've fixed the issue happening on another PR inheriting from base_view_inheritance_extension.
I think it was a corner case.
But, maybe it's worth it for the safety.

StefanRijnhart · 2025-12-17T09:39:40Z

/ocabot migration base_view_inheritance_extension

StefanRijnhart

@yankinmax Oh, thanks for the followup. In that case there is likely no issue in this module. Merging as all comments are covered now.

/ocabot merge nobump

OCA-git-bot · 2025-12-17T09:40:07Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-3382-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot · 2025-12-17T09:43:38Z

Congratulations, your PR was merged at 5a02ef0. Thanks a lot for contributing to OCA. ❤️

bizzappdev force-pushed the 19.0-mig-base_view_inheritance_extension-BAD branch from 6a88440 to 278dae3 Compare September 24, 2025 07:55

bizzappdev marked this pull request as ready for review September 24, 2025 09:32

bizzappdev mentioned this pull request Nov 5, 2025

[19.0][MIG] account_payment_mode_brand: Migration to 19.0 OCA/brand#279

Draft

Reyes4711-S73 approved these changes Nov 13, 2025

View reviewed changes

eugenios73 approved these changes Nov 13, 2025

View reviewed changes

OCA-git-bot added the approved label Nov 13, 2025

jcoux mentioned this pull request Nov 20, 2025

[19.0][MIG] account_operating_unit: Migration to 19.0 OCA/operating-unit#812

Merged

yankinmax mentioned this pull request Nov 21, 2025

[19.0][MIG] sale_operating_unit: Migration to 19.0 OCA/operating-unit#818

Open

5 tasks

astirpe mentioned this pull request Nov 25, 2025

[19.0][MIG] purchase_analytic OCA/account-analytic#852

Draft

sergioM-S73 mentioned this pull request Nov 27, 2025

[19.0][MIG] stock_picking_invoicing: Migration to 19.0 OCA/account-invoicing#2176

Open

alexis-via reviewed Dec 10, 2025

View reviewed changes

hbrunn and others added 17 commits December 12, 2025 17:52

[ADD] base_view_inheritance_extension

d6b7343

[base_view_inheritance_extension] Relicense to LGPL. (OCA#4)

ff46268

[MIG] base_view_inheritance_extension: Migration to 9.0

bd2fe33

Trivial changes: * Version in README changed * Version in manifest changed OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[8.0][ADD] Add list manipulation operations to base_view_inheritance_…

ef05095

…extension. (OCA#804) * Add list_add operation. * Add list_remove operation. OCA Transbot updated translations from Transifex

[MIG] base_view_inheritance_extension to 10.0

b2ef6d8

[FIX] don't break when an attribute node in an xpath makes the

70e67bb

expression not match the node any more. Fixes OCA#885

[FIX] base_view_inheritance_extension: 2 things:

99a048d

* warning about dynamic context * import for safe_eval

[MIG] base_view_inheritance_extension: Migration to 11.0

3c20fa9

[MIG] base_view_inheritance_extension: Migration to 12.0

b40abe9

Remove the "move" feature which is now native

293ee72

Use https in URL to licence

[IMP] base_view_inheritance_extension: black, isort

20f3106

[MIG] base_view_inheritance_extension: Migration to v13.0

12138c0

FIX: add missing params on function apply_inheritance_specs

2a70078

[MIG] base_view_inheritance_extension to v14

df7efa9

Fix apply inheritance specs on views (pre_locate)

b102e16

[IMP] base_view_inheritance_extension: real python_dict

ac43c52

[UPD] base_view_inheritance_extension: readme - deprecate list_add an…

5e2f67a

…d list_remove

alexis-via and others added 13 commits December 12, 2025 17:52

[IMP] base_view_inheritance_extension: pre-commit auto fixes

f7603d6

[MIG] base_view_inheritance_extension to v17

28199cf

[FIX] *: Pre-commit fixes

7d43436

base_view_inheritance_extension: wrap import

af949b4

remove loggin

[FIX] base_view_inheritance_extension: parse old value

6ea8d7d

[MIG] base_view_inheritance_extension: Migration to 18.0

4186407

[MIG] base_view_inheritance_extension: Migration to 18.0 Co-authored-by: Lukas Tran <nhant@trobz.com>

[18.0][FIX]base_view_inheritance_extension: fix deprecation warning w…

73cd62b

…hile using ast.Str.

Added translation using Weblate (Dutch)

5357f6b

[IMP] base_view_inheritance_extension: drop unused dependency

0ded25f

Drops ``astor``: unused external dependency

[MIG] base_view_inheritance_extension: Migration to 19.0

955672f

bizzappdev force-pushed the 19.0-mig-base_view_inheritance_extension-BAD branch from 278dae3 to 955672f Compare December 12, 2025 12:35

AaronHForgeFlow approved these changes Dec 12, 2025

View reviewed changes

OCA-git-bot added the ready to merge label Dec 12, 2025

apami0111 mentioned this pull request Dec 17, 2025

[19.0][MIG] purchase_allowed_product: Migration to 19.0. OCA/purchase-workflow#2906

Merged

OCA-git-bot added this to the 19.0 milestone Dec 17, 2025

OCA-git-bot mentioned this pull request Dec 17, 2025

Migration to version 19.0 #3400

Open

41 tasks

StefanRijnhart approved these changes Dec 17, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 17, 2025

OCA-git-bot merged commit 716ff1f into OCA:19.0 Dec 17, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 17, 2025

Uh oh!

Comments

Conversation

bizzappdev commented Sep 22, 2025

Uh oh!

Reyes4711-S73 left a comment

Choose a reason for hiding this comment

Uh oh!

eugenios73 left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Nov 21, 2025

Uh oh!

alexis-via commented Dec 10, 2025

Uh oh!

alexis-via Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Dec 12, 2025

Uh oh!

StefanRijnhart commented Dec 17, 2025

Uh oh!

yankinmax commented Dec 17, 2025

Uh oh!

StefanRijnhart commented Dec 17, 2025

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Dec 17, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants