[18.0][MIG] auth_user_case_insensitive: Migration to 18.0#756
[18.0][MIG] auth_user_case_insensitive: Migration to 18.0#756El-khamisi wants to merge 22 commits intoOCA:18.0from
Conversation
amh-mw
left a comment
amh-mw
left a comment
There was a problem hiding this comment.
Unfortunately, it looks like you've squashed all the prior commits together. Please take a look at some of the other 18.0 migration pull requests to see what the expected output looks like.
El-khamisi
force-pushed
the
18.0-mig-auth_user_case_insensitive
branch
from
501fad0 to
ad9d922
Compare
…f `_login` * Update code and tests to override `_login` method
Currently translated at 100.0% (2 of 2 strings) Translation: server-auth-12.0/server-auth-12.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_user_case_insensitive/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: server-auth-16.0/server-auth-16.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_user_case_insensitive/es/
Currently translated at 100.0% (4 of 4 strings) Translation: server-auth-16.0/server-auth-16.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_user_case_insensitive/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-17.0/server-auth-17.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_user_case_insensitive/
|
@amh-mw Oh, my bad! Can you review this now? |
amh-mw
left a comment
amh-mw
left a comment
There was a problem hiding this comment.
Per Migration to version 18.0, I would expect two commits at the very end:
- [IMP] auth_user_case_insensitive: pre-commit auto fixes
- [MIG] auth_user_case_insensitive: Migration to 18.0
El-khamisi
force-pushed
the
18.0-mig-auth_user_case_insensitive
branch
from
0dfa869 to
13f74eb
Compare
|
@amh-mw I updated the commit history you can recheck now |
| if credential.get("type") and credential["type"] == "password": | ||
| credential["login"] = credential["login"].lower() | ||
|
|
||
| return super()._login(db, credential, user_agent_env) |
There was a problem hiding this comment.
Changes track with core Odoo implementation of auth_passkey 1:
Footnotes
There was a problem hiding this comment.
I don't get what you mean, can you explain more, please?
There was a problem hiding this comment.
I'm not requesting a change here. I'm just recording that I did a little research into the new signature of the _login method.
There was a problem hiding this comment.
oh, let me get the credential type check back so
amh-mw
left a comment
amh-mw
left a comment
There was a problem hiding this comment.
Need to squash last three commits into one [MIG] auth_user_case_insensitive: Migration to 18.0
El-khamisi
force-pushed
the
18.0-mig-auth_user_case_insensitive
branch
from
f27240d to
734548b
Compare
|
@amh-mw get done |
El-khamisi
force-pushed
the
18.0-mig-auth_user_case_insensitive
branch
from
734548b to
2c59d4a
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
11 participants
No description provided.