Skip to content

[18.0][FIX] payroll: GLOBAL fallback not applied for global resource leaves - #273

Open
cvinh wants to merge 1 commit into
OCA:18.0from
invitu:18.0-fix_payroll_compute_leave_days
Open

[18.0][FIX] payroll: GLOBAL fallback not applied for global resource leaves#273
cvinh wants to merge 1 commit into
OCA:18.0from
invitu:18.0-fix_payroll_compute_leave_days

Conversation

@cvinh

@cvinh cvinh commented May 24, 2026

Copy link
Copy Markdown
Contributor

Steps to Reproduce the Issue :

  • enter public holiday using hr_holidays Odoo standard
  • calculate a payslip for the month of the public holiday
    code GLOBAL is not set... and payslip cannot have an empty code in work days

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @appstogrow, @nimarosa,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@nimarosa

Copy link
Copy Markdown
Contributor

/ocabot rebase

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@nimarosa The rebase process failed, because command git push --force invitu tmp-pr-273:18.0-fix_payroll_compute_leave_days failed with output:

remote: Permission to invitu/payroll.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/invitu/payroll/': The requested URL returned error: 403

as work_entry_type_id is used in _compute_leave_days() method, we have
to inherit hr_work_entry_holidays
@cvinh
cvinh force-pushed the 18.0-fix_payroll_compute_leave_days branch from f31b496 to eb5e9f3 Compare August 17, 2026 21:19
@cvinh

cvinh commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@nimarosa rebased ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants