[19.0][ADD] base_partner_sequence_manual_rank#2299
Open
MarinaAForgeFlow wants to merge 1 commit intoOCA:19.0from
Open
[19.0][ADD] base_partner_sequence_manual_rank#2299MarinaAForgeFlow wants to merge 1 commit intoOCA:19.0from
MarinaAForgeFlow wants to merge 1 commit intoOCA:19.0from
Conversation
luisDIXMIT
approved these changes
Mar 4, 2026
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and tested on runboat, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using base_partner_sequence, the ref field is automatically set in all commercial partners based on a sequence. However, when you use partner_manual_rank and partner_supplier_ref_sequence, it does not make sense to always set the ref field for all commercial partners.
With this module, the ref field is only set for partners marked as customers.