Skip to content

[18.0] [FIX] management_system: Update kanban view#769

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
diggy128:18.0-mgmtsystem_action_kanban
Feb 23, 2026
Merged

[18.0] [FIX] management_system: Update kanban view#769
OCA-git-bot merged 1 commit intoOCA:18.0from
diggy128:18.0-mgmtsystem_action_kanban

Conversation

@diggy128
Copy link
Contributor

Kanban view classes changed in v18

  • This greatly simplifies kanban view to use flex classes
  • Adds a type-color map dict that maps to color index from o-colors in secondary_variables.scss (This removes hard coded colors, promotes uniformity and allows to easily override if needed)
  • Adds computed color field to replace (not working kanban_color) card hightlight color
  • Removes deprecated classes

@pedrobaeza pedrobaeza added this to the 18.0 milestone Feb 22, 2026
@pedrobaeza
Copy link
Member

Can you please put a before/after screenshots?

Please also check the pre-commit.

@diggy128 diggy128 force-pushed the 18.0-mgmtsystem_action_kanban branch 4 times, most recently from de6ba0e to 747937b Compare February 22, 2026 17:40
@diggy128
Copy link
Contributor Author

diggy128 commented Feb 22, 2026

@pedrobaeza
BEFORE:
before

AFTER:
after

Can't get codecov to cover the for loop given the existing test Commit didn't pickup the test changes

@diggy128 diggy128 force-pushed the 18.0-mgmtsystem_action_kanban branch from 747937b to 51fa56d Compare February 22, 2026 17:49
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove [18.0] from the commit message.

}
)
self.assertEqual(new_record.reference, self.env._("SampleReference"))
self.record._compute_color()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need to call the compute method directly.

@diggy128 diggy128 force-pushed the 18.0-mgmtsystem_action_kanban branch from 51fa56d to b6b2361 Compare February 23, 2026 07:44
Kanban view classes changed in v18
- Simplify kanban view to use flex classes
- Add a type-color map dict that maps to color index from o-colors in secondary_variables.scss (This removes hard coded colors, promotes uniformity and allows to easily override if needed)
- Add computed color field to replace (not working kanban_color) card hightlight color
- Remove deprecated classes
@diggy128 diggy128 force-pushed the 18.0-mgmtsystem_action_kanban branch from b6b2361 to 7556435 Compare February 23, 2026 07:52
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-769-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3547bac into OCA:18.0 Feb 23, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at feaff3f. Thanks a lot for contributing to OCA. ❤️

@diggy128 diggy128 deleted the 18.0-mgmtsystem_action_kanban branch February 23, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants