Skip to content

[18.0] [FIX] l10n_it_edi_extension: imported invoices skipped and not notified#5149

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
marcelofrare:18.0-fix-errors-on-invoice-import-xml
Apr 3, 2026
Merged

[18.0] [FIX] l10n_it_edi_extension: imported invoices skipped and not notified#5149
OCA-git-bot merged 1 commit intoOCA:18.0from
marcelofrare:18.0-fix-errors-on-invoice-import-xml

Conversation

@marcelofrare
Copy link
Copy Markdown
Contributor

FIX #5145

@TheMule71
Copy link
Copy Markdown
Contributor

Riassunto discussione discord:

  • invece di modificare il form del wizard, se ci sono fatture non importate si crea un'activity per l'utente che esegue l'import
  • così le fatture create continuano ad essere visualizzate come elenco
  • l'utente può recuperate l'elenco delle fatture non importate in ogni momento

@monen17 monen17 added the needs fixing Has conflicts or is failing mandatory CI checks label Mar 23, 2026
@marcelofrare marcelofrare force-pushed the 18.0-fix-errors-on-invoice-import-xml branch 6 times, most recently from ffb7bca to 088e48f Compare March 29, 2026 08:42
Copy link
Copy Markdown
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questo return va tolto va bene sono fermarsi alla creazione dell'attività.
poi non importare _ usa self.env._ per le traduzioni

@marcelofrare marcelofrare force-pushed the 18.0-fix-errors-on-invoice-import-xml branch from 088e48f to 46a6d91 Compare March 29, 2026 09:12
@marcelofrare marcelofrare requested a review from Borruso March 29, 2026 09:27
@marcelofrare
Copy link
Copy Markdown
Contributor Author

@monen17 fix done

Copy link
Copy Markdown
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional OK

@marcelofrare marcelofrare force-pushed the 18.0-fix-errors-on-invoice-import-xml branch 2 times, most recently from 9c5da74 to 81ff271 Compare March 29, 2026 09:42
Copy link
Copy Markdown
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still functional OK

Copy link
Copy Markdown
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go dito che aprovo!

Copy link
Copy Markdown
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • per la traduzione perfetto
  • attendo per il return

Comment on lines +130 to +140
return {
"type": "ir.actions.client",
"tag": "display_notification",
"params": {
"title": self.env._("Some e-invoices were not imported"),
"message": skipped_info_txt,
"sticky": True,
"next": action,
},
"domain": [("id", "in", moves.ids)],
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bisogna togliere questo return ci deve essere solo il return delle fatture importare

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dovrei aver fatto

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfetto ma ora nel commit c'è anche l'intrastart puoi controllare?

@marcelofrare marcelofrare force-pushed the 18.0-fix-errors-on-invoice-import-xml branch from 81ff271 to a7f68d2 Compare March 29, 2026 14:04
Copy link
Copy Markdown

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

@marcelofrare marcelofrare force-pushed the 18.0-fix-errors-on-invoice-import-xml branch from a7f68d2 to 7db1048 Compare April 2, 2026 18:48
Copy link
Copy Markdown
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mergiate per favore @Borruso puoi approvare per favore?

@MarcoCalcagni
Copy link
Copy Markdown

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-5149-by-MarcoCalcagni-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2dc8d57 into OCA:18.0 Apr 3, 2026
6 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 159b55a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

18.0 merged 🎉 needs fixing Has conflicts or is failing mandatory CI checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errori import fatture xml: non evidenzia fatture non importate

10 participants