[IMP][19.0] Add account_loan_start_end_dates#2239
Open
lmarion-source wants to merge 2 commits intoOCA:19.0from
Open
[IMP][19.0] Add account_loan_start_end_dates#2239lmarion-source wants to merge 2 commits intoOCA:19.0from
lmarion-source wants to merge 2 commits intoOCA:19.0from
Conversation
lmarion-source
force-pushed
the
19.0-lma-account-loan-start-end-dates
branch
5 times, most recently
from
53f9fc2 to
fccdbd7
Compare
AnizR
reviewed
Mar 6, 2026
lmarion-source
force-pushed
the
19.0-lma-account-loan-start-end-dates
branch
from
fccdbd7 to
ef1fd67
Compare
AnizR
reviewed
Mar 6, 2026
petrus-v
reviewed
Mar 6, 2026
Contributor
petrus-v
left a comment
petrus-v
left a comment
There was a problem hiding this comment.
could you improve the documentation, mainly remove templates ?
lmarion-source
force-pushed
the
19.0-lma-account-loan-start-end-dates
branch
2 times, most recently
from
9204806 to
a776cc0
Compare
lmarion-source
force-pushed
the
19.0-lma-account-loan-start-end-dates
branch
from
a776cc0 to
1ed9f26
Compare
petrus-v
approved these changes
Mar 11, 2026
Contributor
petrus-v
left a comment
petrus-v
left a comment
There was a problem hiding this comment.
Code review, looks good to me !
| "If set to true, the start/end dates on the interests will be in the" | ||
| "future compared to the date on the line" | ||
| ), | ||
| required=False, |
Contributor
There was a problem hiding this comment.
This is a bit useless the default value
Suggested change
| required=False, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.