[19.0][MIG] account_loan + refactor by petrus-v · Pull Request #2235 · OCA/account-financial-tools

petrus-v · 2026-02-19T16:18:01Z

implement #2233

This PR is based on #2222 and #2229 with the following additional commits

split account_loan to extract leasing feature in a dedicated module
test and fix [17.0,18.0] accoun_loan: unable to post leasing with residual amount #2234
rename loan_type into loan_method
add loan_type field to set loan / borrow / leasing and easly use filter / group by and cleanup some part of source code

OCA Transbot updated translations from Transifex [UPD] Update account_loan.pot

According to the guidelines: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#importerror Change the logger level from `error` to `debug`.

[UPD] Update account_loan.pot

Loan types info: `APR <https://en.wikipedia.org/wiki/Annual_percentage_rate>`_, `EAR <https://en.wikipedia.org/wiki/Effective_interest_rate>`_, `Real Rate <https://en.wikipedia.org/wiki/Real_interest_rate>`_.

Currently translated at 99.2% (130 of 131 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_loan/de/ Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] Update account_loan.pot [UPD] README.rst

Currently translated at 100.0% (133 of 133 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/de/

Currently translated at 86.1% (142 of 165 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/de/

Currently translated at 100.0% (165 of 165 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/es/

Currently translated at 57.0% (94 of 165 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/pt/

Currently translated at 86.1% (142 of 165 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/de/

Currently translated at 24.8% (41 of 165 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/pt_BR/

Currently translated at 13.9% (23 of 165 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/sl/

Currently translated at 83.6% (138 of 165 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/pt_BR/

Co-authored-by: Enric Tobella <etobella@creublanca.es> [UPD] Update account_loan.pot [UPD] README.rst

[UPD] Update account_loan.pot [UPD] README.rst

account_loan 14.0.1.0.1 account_loan 14.0.1.0.2

Currently translated at 9.0% (15 of 165 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_loan/it/

Currently translated at 45.4% (75 of 165 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_loan/it/

Currently translated at 83.6% (138 of 165 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_loan/pt_BR/

Currently translated at 100.0% (165 of 165 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_loan Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_loan/it/

…ntries: fix read account_loan 14.0.1.0.3

…count_loan

…tency

This will help to distinguish loan/borrow/leasing for enduser and in source code so we can remove is_leasing field.

account_leasing/models/account_loan.py

account_loan/wizards/account_loan_post.py

…other modules

…pare

AnizR

Seems better 👍
Code looks good to me

OCA-git-bot · 2026-03-05T13:49:04Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

petrus-v · 2026-03-05T17:56:37Z

build failures seems related to node 20

before this commit if a contact is used on the loan, account.move.line use it as it but it's better to user commercial partner id on account.move.line to make easier future analysis. So set the contact on the account entries and let the default odoo behavior set the commercial_partner on related account.move.line.

etobella and others added 30 commits February 6, 2026 15:15

[ADD] account_loan

c7a1f49

OCA Transbot updated translations from Transifex [UPD] Update account_loan.pot

[11.0][account_loan] Change logger level on import dependency

d2b13e8

According to the guidelines: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#importerror Change the logger level from `error` to `debug`.

[IMP] Account_loan: Add the option to automatically post invoices

540077b

[UPD] Update account_loan.pot

Add Loan Type info in README

c97459a

Loan types info: `APR <https://en.wikipedia.org/wiki/Annual_percentage_rate>`_, `EAR <https://en.wikipedia.org/wiki/Effective_interest_rate>`_, `Real Rate <https://en.wikipedia.org/wiki/Real_interest_rate>`_.

[11.0][FIX] ValueError: min() arg is an empty sequence

e4987e5

[MIG] account_loan: Migration to 12.0

eb06283

[IMP] account_loan: Fix rounding issues

12a0bf3

[IMP] account_loan: Add fixed-annuity-begin

00265c1

[FIX] test error on multi action_move_create

40ecf26

[UPD] Update account_loan.pot [UPD] README.rst

[IMP] account_loan: black,isort,prettier

f975301

[MIG] account_loan: Migration to 13.0

9c629de

Co-authored-by: Enric Tobella <etobella@creublanca.es> [UPD] Update account_loan.pot [UPD] README.rst

[IMP] *: pre-commit execution

e251a54

[MIG] account_loan: Migration to 14.0

1cce54a

[UPD] Update account_loan.pot [UPD] README.rst

[FIX] account_loan: missing acl line

dc34fcf

[FIX] account_loan: post() -> action_post()

ce2a404

account_loan 14.0.1.0.1 account_loan 14.0.1.0.2

[14.0][FIX] account_loan, account_loan_line & account_loan_generate_e…

0eceffa

…ntries: fix read account_loan 14.0.1.0.3

oca-port: blacklist PR(s) , 1721, 1737, 1750, 1760, 1816, 1952 for ac…

45cecf0

…count_loan

petrus-v marked this pull request as draft February 19, 2026 16:18

petrus-v added 4 commits February 20, 2026 12:13

[MIG] account_loan: forwarded PRs migration

41c070d

[FIX] account_loan: take care of residual_amount while checking consi…

8fa4495

…tency

[REF] account_loan: rename loan_type into loan_method

1246bc8

[REF] account_loan,account_leasing: add loan_type loan/borrow/leasing

7deec92

This will help to distinguish loan/borrow/leasing for enduser and in source code so we can remove is_leasing field.

petrus-v force-pushed the 19.0-mig-account_loan+port+refactor branch from 0288732 to 7deec92 Compare February 20, 2026 11:15

petrus-v marked this pull request as ready for review February 20, 2026 11:22

This was referenced Feb 20, 2026

[19.0][MIG] account_loan #2222

Closed

[19.0] account_loan forward port #2229

Closed

AnizR reviewed Feb 23, 2026

View reviewed changes

account_leasing/models/account_loan.py Outdated Show resolved Hide resolved

account_leasing/models/account_loan.py Outdated Show resolved Hide resolved

account_loan/wizards/account_loan_post.py Outdated Show resolved Hide resolved

petrus-v added 4 commits February 25, 2026 11:03

[REF] account_loan: stop compute laon_type

789e159

[REF] account_leasing: remove compute loan_type support

99ce290

[REF] account_loan,account_leasing: more flexibility to overwrite in …

090a655

…other modules

[FIX] account_loan: use currency compare_amounts instead of float com…

9e34d76

…pare

AnizR approved these changes Feb 25, 2026

View reviewed changes

petrus-v added 2 commits February 25, 2026 17:06

[FIX] account_loan: fix test canceling laon

4b3d843

[FIX] account_loan,account_leasing: really store journal on account_loan

8e63756

AnizR approved these changes Feb 26, 2026

View reviewed changes

lmarion-source approved these changes Mar 5, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 5, 2026

petrus-v force-pushed the 19.0-mig-account_loan+port+refactor branch from 338f713 to a1d6f34 Compare March 5, 2026 17:36

petrus-v mentioned this pull request Mar 6, 2026

CI Failure: Infrastructure issue with deb.nodesource.com (Hash Sum mismatch) OCA/oca-ci#121

Open

[REF] account_loan: support post entries at date

d56a1b1

petrus-v force-pushed the 19.0-mig-account_loan+port+refactor branch from a1d6f34 to d56a1b1 Compare March 6, 2026 09:06

petrus-v force-pushed the 19.0-mig-account_loan+port+refactor branch from e1cb35f to e3a9879 Compare March 6, 2026 14:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] account_loan + refactor#2235

[19.0][MIG] account_loan + refactor#2235
petrus-v wants to merge 99 commits intoOCA:19.0from
acsone:19.0-mig-account_loan+port+refactor

petrus-v commented Feb 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AnizR left a comment

Uh oh!

OCA-git-bot commented Mar 5, 2026

Uh oh!

petrus-v commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

petrus-v commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AnizR left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 5, 2026

Uh oh!

petrus-v commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

petrus-v commented Feb 19, 2026 •

edited

Loading