Skip to content

[MIG][17.0] forward missing commits from 16.0 to 17.0#2224

Open
petrus-v wants to merge 7 commits intoOCA:17.0from
acsone:17.0-forward-port-missing-commits-16-to-17
Open

[MIG][17.0] forward missing commits from 16.0 to 17.0#2224
petrus-v wants to merge 7 commits intoOCA:17.0from
acsone:17.0-forward-port-missing-commits-16-to-17

Conversation

@petrus-v
Copy link
Copy Markdown
Contributor

@petrus-v petrus-v commented Feb 11, 2026

lmarion-source and others added 6 commits February 11, 2026 16:15
@lmarion-source @petrus-v
[IMP] Refactore to add hooks in order to add infos in vals
760f7aa 
    When creating moves or invoices, it can be useful to easily access 'vals' to create move_lines.
@etobella @petrus-v
[FIX] account_loan: Make long term in a better way
6e81086
@AnizR @petrus-v
[IMP] account_loan: add inheritance hook to condition posting of moves
c8ff7a5
@lmarion-source @petrus-v
[IMP] account_loan: Allow to modify currency_id on account loan
280d9c0
@lmarion-source @petrus-v
[IMP] account_loan: Currency not readonly + convert in company currency
8ff4eb5 
    1. We allow to change the currency on the loan if the user needs it

    2. If the currency on the loan (or on the journal) is different from the one on the company, we do the conversion for credit/debit + add amount in currency on the move line
@petrus-v
oca-port: blacklist PR(s) , 1721, 1737, 1750, 1760, 1816, 1952 for ac…
febf5a7 
…count_loan
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 11, 2026

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@petrus-v petrus-v marked this pull request as draft February 11, 2026 16:30
@petrus-v petrus-v force-pushed the 17.0-forward-port-missing-commits-16-to-17 branch from 8170cb6 to b496587 Compare February 11, 2026 16:33
@petrus-v petrus-v marked this pull request as ready for review February 11, 2026 16:35
@petrus-v petrus-v mentioned this pull request Feb 11, 2026
Open
AnizR
AnizR reviewed Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, I'd like to discuss my comment on oca-port's blacklist before approving.

.oca/oca-port/blacklist/account_loan.json
@@ -0,0 +1,11 @@
{
Copy link
Copy Markdown
Contributor

@AnizR AnizR Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file really necessary?
I don't think oca-port's blacklist should be visible in the PR.

Copy link
Copy Markdown
Contributor Author

@petrus-v petrus-v Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this file is followed by git in other repo (ie stock_dynamic_routing module

As far I've understood this is the knowledge to tell to oca-port to ignore those PRs while running it the next time, other wise oca port would suggest again and again those PRs.

@sebalix thanks for such great tool ❤️ , could you confirm:

  • we want share and versioned those files
  • my understanding is correct
  • the kind of message expected here, is it what the PR does or why we decide to ignore it (I admit my first message can be suspicious 😅 )

Copy link
Copy Markdown
Contributor

@lmignon lmignon Feb 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this file should be part of this PR. Once present into the sources it will prevent PRs that have already been submitted and not detected as ported from being proposed on next run of the oca-port command.

@petrus-v petrus-v mentioned this pull request Feb 13, 2026
Closed
lmignon
lmignon approved these changes Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@yvaucher
Copy link
Copy Markdown
Member

yvaucher commented Feb 13, 2026 •
edited
Loading

I find a bit strange the commit [MIG] account_loan: forwarded PRs migration didn't we loose the history here?

@petrus-v
Copy link
Copy Markdown
Contributor Author

petrus-v commented Feb 15, 2026

I find a bit strange the commit [MIG] account_loan: forwarded PRs migration didn't we loose the history here?

I don't think so, changes are mainly migration from 16 to 17, I also introduce some issue (mainly linter and introduce double credit key in the dictionary) while managing conflict with the 17.0 branch that I fix in that commit.

AnizR
AnizR approved these changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 16, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

petrus-v
petrus-v commented Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@petrus-v petrus-v force-pushed the 17.0-forward-port-missing-commits-16-to-17 branch from d62a60d to 5074bae Compare February 20, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lmignon lmignon lmignon approved these changes

@AnizR AnizR AnizR approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@petrus-v @OCA-git-bot @yvaucher @lmignon @AnizR @lmarion-source @etobella