increase char length for cpp path#162
Open
annlew wants to merge 1 commit intoNorESMhub:noresm2_3_developfrom
Open
increase char length for cpp path#162annlew wants to merge 1 commit intoNorESMhub:noresm2_3_developfrom
annlew wants to merge 1 commit intoNorESMhub:noresm2_3_developfrom
Conversation
oyvindseland
approved these changes
Nov 21, 2024
oyvindseland
left a comment
oyvindseland
left a comment
There was a problem hiding this comment.
I can not see any problems with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Increase the char length for path to compiler in chem_pp code
Contributors: @annlew, @sarambl
Reviewers: @gold2718
Purpose of changes: Avoid chemistry preprocessor failure at compilation when path to compiler exceeds 64 characters
Github PR URL:
Changes made to build system: Only chemistry preprocessor when usr_mech_infile is specified in env_build.xml
Changes made to the namelist: None
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None
Change the char length for cpp path from 64 to 256 in chem_pp code.
Test: SMS allactive test with grid = f19_tn14 and compset=NF2000climo with a testmod (mychem) to run the chemistry preprocessor. Fails with current HEAD of noresm2_3_develop, passes with this PR branch.
Issues addressed by this PR:
cam_chempp issue with usr_mech_infile when path to compiler is too long (#160)
addresses #160