Update UDC helpers to use the new UDC contract#823
Open
HACKER097 wants to merge 4 commits intoNethermindEth:mainfrom
Open
Update UDC helpers to use the new UDC contract#823HACKER097 wants to merge 4 commits intoNethermindEth:mainfrom
HACKER097 wants to merge 4 commits intoNethermindEth:mainfrom
Conversation
Collaborator
|
Hey @HACKER097! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #772
Here are the changes I have made:
udcAddressCairoV2to the new addressNewUDCOptions()which makesUDCCairoV2the default valueNote: The
TestPrecomputeAddressForUDCtests still fail, because they rely on hardcoded values from real transactions, which I assume use the old address, so their values will have to be changed too.Please let me know if this is the expected way of updating the address and setting the default value. The
NewUDCOptionsfunctions does feel a bit unnecessary for this tiny change, but also less hackey.