Skip to content

Restructure evaluate for mpolys#2182

Open
SoongNoonien wants to merge 9 commits intoNemocas:masterfrom
SoongNoonien:evaluate_disentangle
Open

Restructure evaluate for mpolys#2182
SoongNoonien wants to merge 9 commits intoNemocas:masterfrom
SoongNoonien:evaluate_disentangle

Conversation

@SoongNoonien
Copy link
Copy Markdown
Contributor

This is a work in progress towards Nemocas/AbstractAlgebra.jl#2225 and #2180. At the moment this introduces some method ambiguities which need to be resolved first. I think if I readjusted this PR to make the f(...) syntax the default I should be able to resolve them without a new AbstractAlgebra release.

Note that I started with the fmpq mpolys and that the other mpoly types of Nemo are still missing.

@fingolfin
Copy link
Copy Markdown
Member

In the meantime this has merge conflicts.

I think if I readjusted this PR to make the f(...) syntax the default I should be able to resolve them without a new AbstractAlgebra release.

What do you mean by that? Let evaluate call f(...) and let that do the actual work?

Personally I am not a great fan, I prefer if such "syntactic sugar" functions stay to their minimum. Alas, that's just my base feeling, if there are technical arguments, I am all ears.

(In the meantime we had an AA release and could have made corresponding changes needed here :-) but we can still do that in the future, too. If it makes sense...)

@SoongNoonien
Copy link
Copy Markdown
Contributor Author

What do you mean by that? Let evaluate call f(...) and let that do the actual work?

Yes.

Personally I am not a great fan, I prefer if such "syntactic sugar" functions stay to their minimum. Alas, that's just my base feeling, if there are technical arguments, I am all ears.

Yes, I'd say so too. But in AbstractAlgebra it is done that way (i.e. evaluate calls f(...)) unfortunately.

@SoongNoonien
Copy link
Copy Markdown
Contributor Author

In the meantime we had an AA release and could have made corresponding changes needed here :-) but we can still do that in the future, too. If it makes sense...

Sorry, I completely forgot about this PR.

Comment thread src/flint/fmpz_mpoly.jl Outdated
@SoongNoonien SoongNoonien force-pushed the evaluate_disentangle branch from 804addb to cd3c390 Compare April 17, 2026 10:12
@SoongNoonien SoongNoonien force-pushed the evaluate_disentangle branch from 3d78bae to 7bb35f1 Compare April 17, 2026 11:33
@SoongNoonien SoongNoonien marked this pull request as ready for review April 17, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants