Remove problematic similar and zero methods for MatRingElem#2283
Draft
Remove problematic similar and zero methods for MatRingElem#2283
similar and zero methods for MatRingElem#2283Conversation
fingolfin
changed the title
similar + zero methods for MatRingElem
fingolfin
force-pushed
the
mh/deprecate-matring
branch
from
647baca to
c454801
Compare
Member
Author
|
Turns out this is used in e.g. |
fingolfin
force-pushed
the
mh/deprecate-matring
branch
from
c454801 to
701387e
Compare
fingolfin
changed the title
similar + zero methods for MatRingElemsimilar and zero methods for MatRingElem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argh, forgot about these, and now 0.48.0 is out. Ah well, perhaps better this way, so that we can get CI tests for this (once everything has updated to 0.48.0).