Compute Solve traits from types as args#2101
Compute Solve traits from types as args#2101lgoettgens wants to merge 3 commits intoNemocas:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2101 +/- ##
==========================================
- Coverage 88.36% 88.36% -0.01%
==========================================
Files 126 126
Lines 31656 31660 +4
==========================================
+ Hits 27974 27975 +1
- Misses 3682 3685 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think the idea was that the "best" matrix normal form does not only depend on the type. For example, a @thofma what do you think? |
|
Yes, the idea was to combine it with something like |
Hmm, I don't really see how to do that without making inference of all of solving impossible. But I am open to any ideas you might have on the matter |
My motivation for this is to be able to set a concrete type in the
@attr Anycall in https://github.com/oscar-system/Oscar.jl/pull/4915/files#diff-88ef12a4e6f091b2cc3dd521d7c8be444dab854cb7aef78f6837778a274315ffR489 (something along the lines of@attr solve_context_type(base_ring_type(M))).I also copied over the two fallbacks (for
::Anyand for::DataType) over from all of the similar functions likebase_ring_typeand then removed some obsolete methods.@joschmitt does this change make sense to you?