Remove double negation in plugin unloaded check#523
Open
Lucasgood5 wants to merge 1 commit intoNebulousCloud:masterfrom
Open
Remove double negation in plugin unloaded check#523Lucasgood5 wants to merge 1 commit intoNebulousCloud:masterfrom
Lucasgood5 wants to merge 1 commit intoNebulousCloud:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes an unnecessary double negation operator (!!) from a boolean variable assignment in the plugin toggle handler. The double negation was being used to coerce the value from ix.plugin.unloaded[uniqueID] into an explicit boolean, but this coercion is unnecessary in Lua because nil and false behave identically in the subsequent boolean context where the variable is used.
Changes:
- Removed double negation operator from
bUnloadedvariable assignment in the plugin toggle network receive handler
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no clue why there is a double ! here.
My custom CI/CD just flagged me this as unusual.
So either there is a good reason, and then a comment should be added.
Or there is no reason, and then we should remove it for code quality.