Skip to content

Remove double negation in plugin unloaded check#523

Open
Lucasgood5 wants to merge 1 commit intoNebulousCloud:masterfrom
Lucasgood5:patch-3
Open

Remove double negation in plugin unloaded check#523
Lucasgood5 wants to merge 1 commit intoNebulousCloud:masterfrom
Lucasgood5:patch-3

Conversation

@Lucasgood5
Copy link
Copy Markdown
Contributor

I have no clue why there is a double ! here.
My custom CI/CD just flagged me this as unusual.
So either there is a good reason, and then a comment should be added.
Or there is no reason, and then we should remove it for code quality.

Copilot AI review requested due to automatic review settings February 27, 2026 16:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes an unnecessary double negation operator (!!) from a boolean variable assignment in the plugin toggle handler. The double negation was being used to coerce the value from ix.plugin.unloaded[uniqueID] into an explicit boolean, but this coercion is unnecessary in Lua because nil and false behave identically in the subsequent boolean context where the variable is used.

Changes:

  • Removed double negation operator from bUnloaded variable assignment in the plugin toggle network receive handler

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants