Skip to content

Conversation

@skinkie
Copy link
Contributor

@skinkie skinkie commented Apr 22, 2025

Fix #857
Fix #874

@skinkie skinkie added the hygiene Technical dept, results in a breaking change. label Apr 22, 2025
@skinkie skinkie self-assigned this Apr 22, 2025
@skinkie skinkie requested a review from duexw April 22, 2025 08:53
@skinkie skinkie changed the title Remove all unreferenced groups with 2nd run Remove all unreferenced groups, complexTypes, simpleTypes Apr 22, 2025
@trurlurl
Copy link
Collaborator

I cannot judge whether everything is really obsolete, so I don't dare approving.

Taking the example of LiftCallEquipmentRefStructure: I guess this is removed because element LiftCallEquipmentRef refers to the more general AccessEquipmentRefStructure. But wouldn't having it refer to LiftCallEquipmentRefStructure be the more proper solution?

PR #811 has been closed assuming that this PR #872 takes care of the changes in the examples. But this isn't the case, is it?

@skinkie
Copy link
Contributor Author

skinkie commented Apr 29, 2025

I cannot judge whether everything is really obsolete, so I don't dare approving.

Taking the example of LiftCallEquipmentRefStructure: I guess this is removed because element LiftCallEquipmentRef refers to the more general AccessEquipmentRefStructure. But wouldn't having it refer to LiftCallEquipmentRefStructure be the more proper solution?

I would tocally agree. Those are actual valid bugs in the existing schema. Therefore we need people to actually validate why some structures are being removed.

PR #811 has been closed assuming that this PR #872 takes care of the changes in the examples. But this isn't the case, is it?

This is I think an unrelated comment. #811 is done in #876.

@ue71603
Copy link
Contributor

ue71603 commented Jun 9, 2025

@skinkie should @Aurige look at this first?

@skinkie
Copy link
Contributor Author

skinkie commented Jun 9, 2025

I guess start with the other assigned issues first, since this has merge conflicts now.

@skinkie skinkie modified the milestones: netex_2.0, netex_3.0 Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hygiene Technical dept, results in a breaking change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants