Decompiler: implement operator associativity handling#9092
Open
liamwhite wants to merge 1 commit intoNationalSecurityAgency:masterfrom
Open
Decompiler: implement operator associativity handling#9092liamwhite wants to merge 1 commit intoNationalSecurityAgency:masterfrom
liamwhite wants to merge 1 commit intoNationalSecurityAgency:masterfrom
Conversation
Contributor
|
Thank you! I've always hated this 😂. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you define some structures like this:
(my general approach to modeling C++ inheritance), and then run it through the decompiler, you get this:
where the left subexpression is unnecessarily parenthesized.
This occurs because the source printer sees they have equal precedence, and thinks there is a conflict because the token types are not the same. In the decompiler's current model, operators can only be self-associative. However, though they do share the same precedence, both direct member access (
.) and pointer member access (->) are actually left-to-right associative. (Associativity is similar in Java.)The proposed change makes all operators have an explicit associativity direction associated with them, which removes the gratuitous parentheses: